Commit Graph

14 Commits

Author SHA1 Message Date
Rémy Coutable a4f7324170
[Review Apps] Don't exit when dependable job fails
The function that retrieves the dependable job is pretty basic and
retrieves the first job found with the matching name, but this job can
be failed but then successfully retried. In that case, we would exit the
depending job even though the dependable job actually succeeded (the
second time). Let's simplify things, be optimistic and continue with the
depending job even if the dependable job fails.

That reverts to the original behavior.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2019-01-17 18:56:41 +01:00
Rémy Coutable 2064565abc Merge branch '55323-review-apps-use-2-replicas-for-the-tiller-deploy-deployment' into 'master'
[Review Apps] Use 2 replicas for the `tiller-deploy` Deployment

Closes #55323

See merge request gitlab-org/gitlab-ce!23806
2019-01-10 12:36:06 +00:00
Mark Lapierre 38a10e3870 Exit as error if job fails
If a script is waiting for a job to be done and that job fails,
exit with an error status so that the script doesn't continue
with a prerequisite in an invalid state.
2018-12-21 18:30:52 +00:00
Rémy Coutable ebf73a19ce
Use 2 replicas for the Deployment
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-12-19 11:23:43 +01:00
Rémy Coutable a76ce8b46b
Specify the 'sync' policy for the external-dns deployments
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-12-18 17:49:53 +01:00
Mark Lapierre 0f751f6f17 Run gitlab:assets:compile on qa jobs
Optionally compiling assets when needed for qa jobs proved
unworkable so instead we fall back on compiling them for
all qa jobs.
2018-12-17 15:30:52 -05:00
Rémy Coutable 73dce6c870
[QA] Better retrieve job ID for a retried job
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-12-06 10:06:15 +01:00
Rémy Coutable f4b8ecbf9f
Add a manual job to run QA against a Review App
1. Renames review to review-deploy.
2. Renames stop_review to review-stop.
3. Adds a build-qa-image job to the prepare stage and save the QA
  Docker image as artifact (example:
  https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/120967019).
4. Adds a manual review-qa job to the test stage to run QA tests
  against the Review App (example:
  https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/120967238).
5. Make the review-deploy job plays the review-qa job as soon as the
  Review App is deployed (example:
  https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/120988775).
6. Updates the Review Apps documentation accordingly.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-11-26 14:49:03 +01:00
Rémy Coutable 4383c7947e
Ensure we abort the cleanup if release is empty
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-11-13 18:01:46 +01:00
Balasankar "Balu" C 2b7ad9da09
Disable usage pings in review apps 2018-11-11 17:15:03 +05:30
Rémy Coutable f7f42cf345
Ensure we create the secrets at the right time
In `deploy`, if the previous deployment failed, we delete/cleanup all
the objects related to the release, including secrets. The problem is
that if we create the root password before that, it will be then
recreated during the deploy with a random value!

By creatigng the secret just before actually deplying a new release, we
ensure that it won't be overriden.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-11-09 12:30:51 +01:00
Ian Baum 41994c2adf Add omitted indentation fix 2018-10-23 10:05:57 -05:00
Ian Baum 58690a63fa Add review app to gitlab-ce
* Uses the same supporting code as used in EE
* Includes automated cleanup
* Install external-dns helm chart to review apps cluster if it isn't
already
* Adds variables REVIEW_APPS_AWS_SECRET_KEY and
REVIEW_APPS_AWS_ACCESS_key
* review-apps-ce uses a different cipher
2018-10-23 10:05:57 -05:00
Rémy Coutable 3299680cdd
[CE] Port review apps file to CE
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-09-25 16:41:27 +02:00