Commit graph

26 commits

Author SHA1 Message Date
Filipa Lacerda
412c9e8b95 Merge branch 'create-collapsed-todo-button' into 'master'
Added initial todo functionality to collapsed sidebar

Closes #24805

See merge request !7827
2017-03-29 13:41:12 +00:00
Phil Hughes
930069052b Fixed labels icon being hidden in collapsed issuable sidebar 2017-03-28 16:33:49 +00:00
Phil Hughes
89d1a1c097 Added specs for collapsed sidebar 2017-03-27 16:02:20 +01:00
Mike Greiling
29e0cb4b91 Organize our polyfills and standardize on core-js 2017-03-13 21:48:32 +00:00
Mike Greiling
c74b7eb271 fix overlooked window binding in spec files 2017-02-17 17:02:14 -06:00
winniehell
d8517fd457 Replace static fixture for right_sidebar_spec.js (!9211) 2017-02-14 12:04:35 +01:00
Mike Greiling
69e4072f89 Merge branch 'master' into go-go-gadget-webpack
* master: (389 commits)
  Document "No gems fetched from git repositories" policy [ci skip]
  Typos
  Small gramatical tweaks
  Typos
  Added PHP & NPM doc
  Use `:empty_project` where possible in request specs
  Add caching of droplab ajax requests
  Use `:empty_project` where possible in model specs
  Revert 3f17f29a
  Remove unused js response from refs controller
  Add MR id to changelog entry
  fixed small mini pipeline graph line glitch
  Prevent form to be submitted twice
  Fix Error 500 when repositories contain annotated tags pointing to blobs
  Fix /explore sorting (trending)
  Simplify wording in "adding an image" docs
  Remove "official merge window" from CONTRIBUTING.md [ci skip]
  Update repository check documentation
  Fixed flexbox and wrap issues
  Update two_factor_authentication.md
  ...
2017-01-27 19:33:58 -06:00
Mike Greiling
ccada28f30 resolve all padded-blocks eslint violations 2017-01-18 17:16:41 -06:00
Mike Greiling
e7b5945c59 resolve all semi and no-extra-semi eslint violations 2017-01-18 17:15:27 -06:00
Mike Greiling
5bb258cd8f phantomJS doesn't allow us to spyOn history.replaceState 2017-01-13 11:06:58 -05:00
Mike Greiling
8d2099cb53 use ~ to reference non-local scripts instead of resolve.root 2017-01-10 12:30:43 -06:00
Mike Greiling
b0341c14d0 move additional libraries into spec_helper 2017-01-10 12:30:43 -06:00
Mike Greiling
52c6702ec7 include spec_helper within karma config rather than each individual test 2017-01-10 12:30:43 -06:00
Mike Greiling
7837fe46f0 fix broken js.cookie imports 2017-01-10 12:30:41 -06:00
Luke "Jared" Bennett
7c47cc94c5 Swapped out teaspoon for karma 2017-01-10 12:30:40 -06:00
Mike Greiling
f19330e4fb fix right_sidebar_spec ajax call 2017-01-05 14:11:19 -06:00
Mike Greiling
7a2a9bb45e replace Teaspoon fixture methods with jasmine-jquery methods to reduce dependency on Teaspoon 2017-01-05 14:11:07 -06:00
Mike Greiling
8e0e902b13 resolve all instances of no-undef eslint rule violations 2016-12-14 02:11:13 -06:00
winniehell
bc1b305dcf Replace static fixture for right_sidebar_spec (!7687) 2016-11-28 20:34:45 +01:00
Luke "Jared" Bennett
7cefaea876
explicitly disable eslint inline 2016-11-15 16:30:34 +00:00
Fatih Acet
f879319840 Merge branch 'add-todo-toggle-event' into 'master'
Add todo toggle event

## What does this MR do?
Adds a custom jQuery event `todo:toggle` to detect when a new todo is added so that the respective todo counters (header navigation and sidebar) can update as needed

## Are there points in the code the reviewer needs to double check?

*  I wasn't sure whether each `spec` should be modularized based on the html templates or whether they should be separated based on function. There are some crossovers between the `dashboard_spec` and the `header_spec`.
* The naming conventions for `sidebar` and `right_sidebar` were a little confusing since they were named the opposite in their `specs`. I made a few assumptions and named a few files based on what I thought they should be named. I'd be happy to change it to something else though 😄  

## Why was this MR needed?
This resolves an existing issue where the todo count on the sidebar would not update (until refresh) and refactors the existing methods that are used to update the todo counters (header navigation and sidebar)

## What are the relevant issue numbers?
Closes #20140

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5724
2016-10-27 13:28:40 +00:00
Clement Ho
f610f69ab9 Add todo toggle event 2016-10-26 16:28:56 -05:00
winniehell
02f94cf038 disable ESLint for all JavaScript files 2016-10-26 10:02:58 +02:00
Mike Greiling
67d2b2acb3 replace jquery.cookie vendor script with js.cookie 2016-10-24 18:09:00 -05:00
Jared Deckard
7f6474b269 Restore comments lost when converting CoffeeScript to JavaScript 2016-09-08 12:23:12 -05:00
Fatih Acet
aaa9509d12 ES6ify all the things! 2016-07-24 23:45:11 +03:00