kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss

Fork 0

Commit graph

Author	SHA1	Message	Date
Stan Hu	fc5ebc3cb8	Fix uninitialized constant with GitLab Pages deploy pages:deploy step was failing with the following error: ``` unitialized constant SafeZip::Extract::Zip ``` Since license_finder already pulls in rubyzip, we can make it a required gem. We also use the scope operator to make the reference to Zip::File explicit.	2019-01-31 16:52:51 +01:00
Kamil Trzciński	66744469d4	Extract GitLab Pages using RubyZip RubyZip allows us to perform strong validation of expanded paths where we do extract file. We introduce the following additional checks to extract routines: 1. None of path components can be symlinked, 2. We drop privileges support for directories, 3. Symlink source needs to point within the target directory, like `public/`, 4. The symlink source needs to exist ahead of time.	2019-01-31 16:52:48 +01:00

Author

SHA1

Message

Date

Stan Hu

fc5ebc3cb8

Fix uninitialized constant with GitLab Pages deploy

pages:deploy step was failing with the following error:

```
unitialized constant SafeZip::Extract::Zip
```

Since license_finder already pulls in rubyzip, we can make it
a required gem. We also use the scope operator to make the reference to
Zip::File explicit.

2019-01-31 16:52:51 +01:00

Kamil Trzciński

66744469d4

Extract GitLab Pages using RubyZip

RubyZip allows us to perform strong validation of
expanded paths where we do extract file.

We introduce the following additional checks
to extract routines:

1. None of path components can be symlinked,
2. We drop privileges support for directories,
3. Symlink source needs to point within the target directory,
   like `public/`,
4. The symlink source needs to exist ahead of time.

2019-01-31 16:52:48 +01:00

2 commits