aeb67dd489
Upgrade to Rails 5.2
...
Updates changed method names and fixes spec failures
2019-07-12 10:15:31 +08:00
93a44e135b
Add some frozen string to spec/**/*.rb
...
Adds frozen string to the following:
* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb
xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
ebb284c0dc
Remove N+1 query for tags in /admin/runners page
...
As discussed in https://github.com/mbleigh/acts-as-taggable-on/issues/91 ,
we can avoid N+1 queries if we use `tags` instead of `tag_list`.
Seen while reviewing
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19740 .
2019-02-26 12:44:28 -08:00
b44a2c801a
Update specs to rails5 format
...
Updates specs to use new rails5 format.
The old format:
`get :show, { some: params }, { some: headers }`
The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
2f40dac352
Refactor `have_http_status` into `have_gitlab_http_status` in the specs
2017-10-20 10:13:18 +02:00
60288d6c62
Use expect { }.to change { }
...
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8664#note_23427575
2017-02-15 20:21:51 +08:00
3856a3daa1
Add some tests for admin/project runners page
2017-02-15 19:16:12 +08:00
Heinrich Lee Yu