Commit graph

10 commits

Author SHA1 Message Date
micael.bergeron
486da72f28 fix a wrong method call in the refactor 2017-10-12 09:18:15 -04:00
micael.bergeron
e5ed2e4f4e fix multiple notifications from being sent for multiple labels
This also refactor the email_helper support spec to watch for multiple
emails being sent.
2017-10-10 14:45:43 -04:00
Lin Jen-Shin
2c09d2a13d Test against notification email 2016-10-21 18:22:09 +08:00
Lin Jen-Shin
045c671533 Use bcc for pipeline emails because:
We use bcc here because we don't want to generate this emails for a
thousand times. This could be potentially expensive in a loop, and
recipients would contain all project watchers so it could be a lot.
2016-10-18 20:02:35 +08:00
Lin Jen-Shin
98217bc067 should_email_no_one -> should_not_email_anyone, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342/diffs#note_17039876
2016-10-17 18:05:19 +08:00
Lin Jen-Shin
9622ef64e4 Introduce email_recipients and use include? Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342#note_16075554
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342#note_16075622
2016-10-17 07:25:20 +00:00
Lin Jen-Shin
beb47c257a Try to slightly optimize EmailHeleprs 2016-10-17 07:25:20 +00:00
Lin Jen-Shin
572585665f Use EmailHelpers where possible, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342#note_15434860
2016-10-17 07:25:20 +00:00
Nick Thomas
0e9c4a902d DRY up the added update service specs, add two email helpers 2016-08-16 17:08:43 +01:00
Timothy Andrew
0444fa560a Original implementation to allow users to subscribe to labels
1. Allow subscribing (the current user) to a label

- Refactor the `Subscription` coffeescript class
  - The main change is that it accepts a container, and conducts all
    DOM queries within its scope. We need this because the labels
    page has multiple instances of `Subscription` on the same page.

2. Creating an issue or MR with labels notifies users subscribed to those labels

- Label `has_many` subscribers through subscriptions.

3. Adding a label to an issue or MR notifies users subscribed to those labels

- This only applies to subscribers of the label that has just been
  added, not all labels for the issue.
2016-03-15 17:25:37 +01:00