gitlab-org--gitlab-foss/spec
Douwe Maan 33d8972bf9 Merge branch 'fix-18717' into 'master'
Ensure that group owner cannot request access to a project of their group

## What does this MR do?

It fixes two things:

- 91ad995d69e1a0f8991fd896f1d9febc109273fe Ensure that group owner cannot request access to a project of their group
- ec3ff061148d556757e7cd486cdc6083d77acf34 Ensure group/project owners can see their members' access_level (see the commit message for details)

## Are there points in the code the reviewer needs to double check?

Not really, these are pretty simple fixes.

## Why was this MR needed?

Because there was an issue created!

## What are the relevant issue numbers?

Fixes #18717.

## Does this MR meet the acceptance criteria?

- [x] CHANGELOG is not needed since the bug is only present in a 8.9 RC
- [x] Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4729
2016-06-17 22:47:19 +00:00
..
config
controllers Merge branch 'issuable-todo-improvements' 2016-06-18 00:42:36 +02:00
factories Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
features Merge branch 'fix-18717' into 'master' 2016-06-17 22:47:19 +00:00
finders Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
fixtures Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
helpers Ensure group/project owners can see their members' access_level 2016-06-17 13:03:19 +02:00
initializers
javascripts Merge branch '13525-sane-defaults-for-merge-request-js-class-constructor' into 'master' 2016-06-16 18:32:23 +00:00
lib Track method call times/counts as a single metric 2016-06-17 13:09:55 -04:00
mailers Add previews for all customized Devise emails 2016-06-16 20:10:52 -04:00
models Merge branch '14918-add-filter-dropdown-to-tag-page' into 'master' 2016-06-17 15:41:59 +00:00
requests fixup! updated docs for api endpoint award emoji 2016-06-17 22:03:57 +02:00
routing
services Cache todo counters (pending/done) 2016-06-17 19:04:36 +02:00
support Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into feature/project-export 2016-06-16 13:04:00 +02:00
tasks/gitlab
views
workers Merge branch 'repo-check-require-push-events' into 'master' 2016-06-17 19:14:43 +00:00
factories_spec.rb Enable RSpec/NotToNot cop and auto-correct offenses 2016-05-24 15:40:29 -04:00
rails_helper.rb
spec_helper.rb Enable Knapsack only in CI environment 2016-06-08 11:43:13 +02:00
teaspoon_env.rb