Find a file
Douwe Maan 33d8972bf9 Merge branch 'fix-18717' into 'master'
Ensure that group owner cannot request access to a project of their group

## What does this MR do?

It fixes two things:

- 91ad995d69e1a0f8991fd896f1d9febc109273fe Ensure that group owner cannot request access to a project of their group
- ec3ff061148d556757e7cd486cdc6083d77acf34 Ensure group/project owners can see their members' access_level (see the commit message for details)

## Are there points in the code the reviewer needs to double check?

Not really, these are pretty simple fixes.

## Why was this MR needed?

Because there was an issue created!

## What are the relevant issue numbers?

Fixes #18717.

## Does this MR meet the acceptance criteria?

- [x] CHANGELOG is not needed since the bug is only present in a 8.9 RC
- [x] Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4729
2016-06-17 22:47:19 +00:00
.github
app Merge branch 'fix-18717' into 'master' 2016-06-17 22:47:19 +00:00
bin Use ENABLE_SPRING to use it by default 2016-06-17 16:54:55 +02:00
builds
config Merge branch 'issuable-todo-improvements' 2016-06-18 00:42:36 +02:00
db Merge branch '2979-personal-access-tokens' into 'master' 2016-06-17 14:40:24 +00:00
doc fixup! updated docs for api endpoint award emoji 2016-06-17 22:03:57 +02:00
docker
features Ensure Todos counters doesn't count Todos for projects pending delete 2016-06-17 16:17:43 -03:00
fixtures/emojis
generator_templates/active_record/migration
lib Merge branch 'gh-webhooks' into 'master' 2016-06-17 22:03:57 +00:00
log
public
scripts Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
shared
spec Merge branch 'fix-18717' into 'master' 2016-06-17 22:47:19 +00:00
tmp
vendor Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
.csscomb.json
.flayignore
.foreman
.gitattributes
.gitignore
.gitlab-ci.yml Add master-only limitation. 2016-06-17 09:48:46 -06:00
.hound.yml
.pkgr.yml
.rspec
.rubocop.yml Revert "squashed merge and fixed conflicts" 2016-06-16 12:59:07 +02:00
.ruby-version
.scss-lint.yml
.simplecov
.teatro.yml
.vagrant_enabled
CHANGELOG Merge branch 'api-endpoints-award-emoji' into 'master' 2016-06-17 20:49:36 +00:00
config.ru
CONTRIBUTING.md
doc_styleguide.md
docker-compose.yml
Gemfile Merge branch 'feature/project-export' into 'master' 2016-06-17 15:35:27 +00:00
Gemfile.lock Merge branch 'feature/project-export' into 'master' 2016-06-17 15:35:27 +00:00
GITLAB_SHELL_VERSION
GITLAB_WORKHORSE_VERSION
LICENSE
MAINTENANCE.md
PROCESS.md
Procfile
Rakefile
README.md
VERSION

GitLab

build status Code Climate

Canonical source

The source of GitLab Community Edition is hosted on GitLab.com and there are mirrors to make contributing as easy as possible.

Open source software to collaborate on code

To see how GitLab looks please see the features page on our website.

  • Manage Git repositories with fine grained access controls that keep your code secure
  • Perform code reviews and enhance collaboration with merge requests
  • Each project can also have an issue tracker and a wiki
  • Used by more than 100,000 organizations, GitLab is the most popular solution to manage Git repositories on-premises
  • Completely free and open source (MIT Expat license)
  • Powered by Ruby on Rails

Hiring

We're hiring developers, support people, and production engineers all the time, please see our jobs page.

Editions

There are two editions of GitLab:

  • GitLab Community Edition (CE) is available freely under the MIT Expat license.
  • GitLab Enterprise Edition (EE) includes extra features that are more useful for organizations with more than 100 users. To use EE and get official support please become a subscriber.

Website

On about.gitlab.com you can find more information about:

Requirements

Please see the requirements documentation for system requirements and more information about the supported operating systems.

Installation

The recommended way to install GitLab is with the Omnibus packages on our package server. Compared to an installation from source, this is faster and less error prone. Just select your operating system, download the respective package (Debian or RPM) and install it using the system's package manager.

There are various other options to install GitLab, please refer to the installation page on the GitLab website for more information.

You can access a new installation with the login root and password 5iveL!fe, after login you are required to set a unique password.

Install a development environment

To work on GitLab itself, we recommend setting up your development environment with the GitLab Development Kit. If you do not use the GitLab Development Kit you need to install and setup all the dependencies yourself, this is a lot of work and error prone. One small thing you also have to do when installing it yourself is to copy the example development unicorn configuration file:

cp config/unicorn.rb.example.development config/unicorn.rb

Instructions on how to start GitLab and how to run the tests can be found in the development section of the GitLab Development Kit.

Software stack

GitLab is a Ruby on Rails application that runs on the following software:

  • Ubuntu/Debian/CentOS/RHEL
  • Ruby (MRI) 2.1
  • Git 2.7.4+
  • Redis 2.8+
  • MySQL or PostgreSQL

For more information please see the architecture documentation.

Third-party applications

There are a lot of third-party applications integrating with GitLab. These include GUI Git clients, mobile applications and API wrappers for various languages.

GitLab release cycle

For more information about the release process see the release documentation.

Upgrading

For upgrading information please see our update page.

Documentation

All documentation can be found on doc.gitlab.com/ce/.

Getting help

Please see Getting help for GitLab on our website for the many options to get help.

Is it any good?

Yes

Is it awesome?

Thanks for asking this question Joshua. These people seem to like it.