gitlab-org--gitlab-foss/app/finders
Luke Duncalfe 37b17fa61a Add service classes for mutating AwardEmoji
Adding, destroying and toggling emoji previously lacked services and
instead were performed through methods called on Awardable models.

This led to inconsistencies where relevant todos would be marked as done
only when emoji were awarded through our controllers, but not through
the API. Todos could also be marked as done when an emoji was being
removed.

Behaviour changes

- Awarding emoji through the API will now mark a relevant Todo as done
- Toggling an emoji off (destroying it) through our controllers will no
  longer mark a relevant Todo as done

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
2019-08-21 11:39:41 +12:00
..
admin
autocomplete
boards
clusters
concerns
projects
README.md
access_requests_finder.rb
applications_finder.rb
award_emojis_finder.rb Add service classes for mutating AwardEmoji 2019-08-21 11:39:41 +12:00
branches_finder.rb
cluster_ancestors_finder.rb
clusters_finder.rb
container_repositories_finder.rb
contributed_projects_finder.rb
environments_finder.rb
events_finder.rb
fork_projects_finder.rb
group_descendants_finder.rb
group_finder.rb
group_labels_finder.rb
group_members_finder.rb
group_projects_finder.rb
groups_finder.rb
issuable_finder.rb
issues_finder.rb
joined_groups_finder.rb
labels_finder.rb
license_template_finder.rb
members_finder.rb
merge_request_target_project_finder.rb
merge_requests_finder.rb
milestones_finder.rb
notes_finder.rb
pending_todos_finder.rb
personal_access_tokens_finder.rb
personal_projects_finder.rb
pipeline_schedules_finder.rb
pipelines_finder.rb
projects_finder.rb
releases_finder.rb
runner_jobs_finder.rb
snippets_finder.rb
starred_projects_finder.rb
tags_finder.rb
template_finder.rb
todos_finder.rb
union_finder.rb
user_finder.rb
user_recent_events_finder.rb
users_finder.rb
users_star_projects_finder.rb
users_with_pending_todos_finder.rb

README.md

Finders

This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:

class Project
  def issues_for_user_filtered_by(user, filter)
    # A lot of logic not related to project model itself
  end
end

issues = project.issues_for_user_filtered_by(user, params)

Better use this:

issues = IssuesFinder.new(project, user, filter).execute

It will help keep models thiner.