37b17fa61a
Adding, destroying and toggling emoji previously lacked services and instead were performed through methods called on Awardable models. This led to inconsistencies where relevant todos would be marked as done only when emoji were awarded through our controllers, but not through the API. Todos could also be marked as done when an emoji was being removed. Behaviour changes - Awarding emoji through the API will now mark a relevant Todo as done - Toggling an emoji off (destroying it) through our controllers will no longer mark a relevant Todo as done Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63372
55 lines
1.1 KiB
Ruby
55 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class AwardEmojisFinder
|
|
attr_reader :awardable, :params
|
|
|
|
def initialize(awardable, params = {})
|
|
@awardable = awardable
|
|
@params = params
|
|
|
|
validate_params
|
|
end
|
|
|
|
def execute
|
|
awards = awardable.award_emoji
|
|
awards = by_name(awards)
|
|
awards = by_awarded_by(awards)
|
|
awards
|
|
end
|
|
|
|
private
|
|
|
|
def by_name(awards)
|
|
return awards unless params[:name]
|
|
|
|
awards.named(params[:name])
|
|
end
|
|
|
|
def by_awarded_by(awards)
|
|
return awards unless params[:awarded_by]
|
|
|
|
awards.awarded_by(params[:awarded_by])
|
|
end
|
|
|
|
def validate_params
|
|
return unless params.present?
|
|
|
|
validate_name_param
|
|
validate_awarded_by_param
|
|
end
|
|
|
|
def validate_name_param
|
|
return unless params[:name]
|
|
|
|
raise ArgumentError, 'Invalid name param' unless params[:name].in?(Gitlab::Emoji.emojis_names)
|
|
end
|
|
|
|
def validate_awarded_by_param
|
|
return unless params[:awarded_by]
|
|
|
|
# awarded_by can be a `User`, or an ID
|
|
unless params[:awarded_by].is_a?(User) || params[:awarded_by].to_s.match(/\A\d+\Z/)
|
|
raise ArgumentError, 'Invalid awarded_by param'
|
|
end
|
|
end
|
|
end
|