kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/models
History
Douwe Maan 9c9e88da56 Merge branch 'fix/error-when-invalid-branch-for-new-pipeline-used' into 'master' 
Fix error when using invalid branch name when creating a new pipeline

## What does this MR do?

This MR fixes `500` error when creating a new pipeline though user interface ("Run pipeline")

## Are there points in the code the reviewer needs to double check?

Is this a good approach to catch those exceptions on `Repository` level?

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
  - [x] Added for this feature/bug

## What are the relevant issue numbers?

Closes #23982

See merge request !7324
 		2016-11-10 14:00:55 +00:00
..
ci Merge remote-tracking branch 'upstream/master' into pipeline-notifications 2016-11-02 16:18:21 +08:00
concerns Merge branch '22481-honour-issue-visibility-for-groups' into 'security' 2016-11-09 12:24:13 +01:00
cycle_analytics fixed newline 2016-10-12 14:30:49 +02:00
hooks Remove schema annotations completely 2016-09-16 14:37:48 +03:00
issue Add a be_like_time matcher and use it in specs 2016-10-17 14:44:20 +01:00
members Optimize Event queries by removing default order 2016-10-27 20:07:11 -03:00
merge_request Add a be_like_time matcher and use it in specs 2016-10-17 14:44:20 +01:00
network Fix Error 500 resulting when loading network graph 2016-08-20 09:57:20 -07:00
project_services Merge remote-tracking branch 'upstream/master' into pipeline-notifications 2016-11-08 23:52:17 +08:00
ability_spec.rb Project tools visibility level 2016-09-01 11:47:59 -03:00
abuse_report_spec.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
appearance_spec.rb Use build instead create record in appearance_spec 2016-10-12 10:50:01 +05:00
application_setting_spec.rb Refine Git garbage collection 2016-11-04 14:30:11 +01:00
award_emoji_spec.rb
…
blob_spec.rb Handle encoding in non-binary Blob instances 2016-09-14 14:15:31 +02:00
board_spec.rb The lists: Backlog, and Done cannot be destroyed 2016-08-17 12:58:57 -03:00
broadcast_message_spec.rb Now we already included it in spec_helper.rb 2016-08-20 00:11:03 +08:00
build_spec.rb Rename ignored to failed_but_allowed, introduce exclude_ignored 2016-10-03 18:22:51 +08:00
commit_range_spec.rb Use JavaScript tooltips for mentions (!5301) 2016-09-01 01:21:34 +02:00
commit_spec.rb There's no such method 2016-11-04 00:00:03 +08:00
commit_status_spec.rb Add test for CommitStatus.exclude_ignored 2016-10-03 18:56:32 +08:00
compare_spec.rb switch from diff_file_collection to diffs 2016-08-03 07:00:20 +02:00
deploy_key_spec.rb Remove unused lets from deploy_key spec 2016-10-12 10:46:30 +05:00
deploy_keys_project_spec.rb
…
deployment_spec.rb Work on specs 2016-10-17 17:10:26 +02:00
diff_note_spec.rb Optimize discussion notes resolving and unresolving 2016-09-06 12:14:09 -03:00
discussion_spec.rb Optimize discussion notes resolving and unresolving 2016-09-06 12:14:09 -03:00
email_spec.rb refactor(email): use setter method instead AR callbacks 2016-10-23 17:30:07 +05:00
environment_spec.rb Fix remaining offenses 2016-10-18 13:51:12 +02:00
event_spec.rb Merge branch '23403-fix-events-for-private-project-features' into 'security' 2016-11-09 12:27:41 +01:00
external_issue_spec.rb Add the method ExternalIssue#project_id 2016-11-07 12:49:24 +01:00
forked_project_link_spec.rb Enforce the fork_project permission in Projects::CreateService 2016-09-27 13:17:56 +01:00
generic_commit_status_spec.rb Avoid `describe`-ing symbols in specs 2016-07-12 10:27:58 -05:00
global_milestone_spec.rb Ensure milestones passed to GlobalMilestone is an ActiveRecord::Relation 2016-09-23 13:34:39 +02:00
group_label_spec.rb Remove order-dependent expectation 2016-11-09 19:50:32 +01:00
group_spec.rb Revert "Revert "Change "Group#web_url" to return "/groups/twitter" rather than "/twitter"."" 2016-10-27 16:16:15 +03:00
guest_spec.rb Merge branch 'fix-unathorized-cloning' into 'security' 2016-11-09 12:27:17 +01:00
identity_spec.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
issue_collection_spec.rb Process commits in a separate worker 2016-11-07 13:11:44 +01:00
issue_spec.rb Merge branch 'issue_23548_dev' into 'master' 2016-11-09 12:25:17 +01:00
key_spec.rb Remove empty describe block on key spec model 2016-10-11 11:02:53 +05:00
label_link_spec.rb Build instead create in label_link model spec 2016-10-11 10:58:46 +05:00
label_priority_spec.rb Add support to group labels prioritization on project level 2016-10-19 14:58:27 -02:00
label_spec.rb Abstract LabelPriority away into methods on Label model 2016-10-19 14:58:27 -02:00
legacy_diff_note_spec.rb Store discussion_id on Note for faster discussion lookup. 2016-08-17 12:16:46 -05:00
list_spec.rb Add a movable scope and a movable? method to List model 2016-08-17 12:58:59 -03:00
member_spec.rb Members::RequestAccessService is tricter on permissions 2016-10-03 10:06:40 +02:00
merge_request_diff_spec.rb Better tests for MergeRequestDiff#compare_with method 2016-10-12 16:32:57 +03:00
merge_request_spec.rb Complete and improve specs 2016-11-04 14:58:40 +01:00
milestone_spec.rb Allowing ">" to be used for Milestone models's title and storing the value in db as unescaped. 2016-09-29 19:28:38 -07:00
namespace_spec.rb Correct namespace validation to forbid bad names #21077 2016-10-07 13:46:59 -05:00
note_spec.rb remove Ability.abilities 2016-08-30 11:35:06 -07:00
notification_setting_spec.rb Exclude projects pending delete from notifications 2016-07-07 20:49:17 +01:00
personal_access_token_spec.rb
…
project_feature_spec.rb Add visibility level to project repository 2016-10-17 18:12:18 -02:00
project_group_link_spec.rb Merge branch 'api-fix-project-group-sharing' into 'security' 2016-10-11 20:36:26 +02:00
project_label_spec.rb Add subject to group and projects labels which return group/project 2016-10-19 14:58:27 -02:00
project_snippet_spec.rb
…
project_spec.rb implements reset incoming email token on issues modal and account page, 2016-11-07 15:56:18 +00:00
project_team_spec.rb Fix specs that requires an access request 2016-09-22 11:12:17 +02:00
project_wiki_spec.rb
…
protected_branch_spec.rb Support wildcard matches for protected branches at the model level. 2016-07-05 10:50:34 +05:30
release_spec.rb
…
repository_spec.rb Merge branch 'fix/error-when-invalid-branch-for-new-pipeline-used' into 'master' 2016-11-10 14:00:55 +00:00
service_spec.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
snippet_spec.rb Add markdown cache columns to the database, but don't use them yet 2016-10-07 02:54:25 +01:00
spam_log_spec.rb
…
todo_spec.rb
…
tree_spec.rb
…
trending_project_spec.rb Precalculate trending projects 2016-10-10 12:27:08 +02:00
user_agent_detail_spec.rb Further refactor and syntax fixes. 2016-08-15 17:20:57 -05:00
user_spec.rb Add User#projects_with_reporter_access_limited_to 2016-11-07 12:49:24 +01:00
wiki_page_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00