gitlab-org--gitlab-foss/app/finders
Bob Van Landuyt 452bc36d60 Rework retry strategy for remote mirrors
**Prevention of running 2 simultaneous updates**

Instead of using `RemoteMirror#update_status` and raise an error if
it's already running to prevent the same mirror being updated at the
same time we now use `Gitlab::ExclusiveLease` for that.

When we fail to obtain a lease in 3 tries, 30 seconds apart, we bail
and reschedule. We'll reschedule faster for the protected branches.

If the mirror already ran since it was scheduled, the job will be
skipped.

**Error handling: Remote side**

When an update fails because of a `Gitlab::Git::CommandError`, we
won't track this error in sentry, this could be on the remote side:
for example when branches have diverged.

In this case, we'll try 3 times scheduled 1 or 5 minutes apart.

In between, the mirror is marked as "to_retry", the error would be
visible to the user when they visit the settings page.

After 3 tries we'll mark the mirror as failed and notify the user.

We won't track this error in sentry, as it's not likely we can help
it.

The next event that would trigger a new refresh.

**Error handling: our side**

If an unexpected error occurs, we mark the mirror as failed, but we'd
still retry the job based on the regular sidekiq retries with
backoff. Same as we used to

The error would be reported in sentry, since its likely we need to do
something about it.
2019-08-13 20:52:01 +00:00
..
admin add tag filter to admin runners page 2019-02-27 20:19:49 +01:00
autocomplete Removed project autocomplete pagination 2019-07-22 11:44:20 +00:00
boards Move Multiple Issue Boards for Projects to Core 2019-06-26 12:28:00 +03:00
clusters Use separate Kubernetes namespaces per environment 2019-08-07 04:40:29 +00:00
concerns Ignore ordering when calling find_by on finders 2019-02-20 11:31:06 +00:00
projects Use separate Kubernetes namespaces per environment 2019-08-07 04:40:29 +00:00
access_requests_finder.rb Enable frozen string in app/graphql + app/finders 2018-09-11 12:15:23 -07:00
applications_finder.rb Disable offense on the appropriate line only !22296 2018-10-19 08:28:44 +09:00
awarded_emoji_finder.rb Refactor AutocompleteController 2018-08-20 13:53:00 +02:00
branches_finder.rb Use select instead of filter to support 2.5 2019-08-05 16:07:26 +00:00
cluster_ancestors_finder.rb Use finder to decide to show note to user 2018-12-17 09:51:53 +13:00
clusters_finder.rb Abstract out project out of ClustersController 2018-11-01 19:36:58 +13:00
container_repositories_finder.rb Add group level container repository endpoints 2019-08-05 20:00:50 +00:00
contributed_projects_finder.rb Fix contributed projects finder shown private info 2019-01-31 16:51:16 +01:00
environments_finder.rb Add name & search parameters to project environments API 2019-06-24 12:18:40 +00:00
events_finder.rb Hide confidential events in ruby 2018-12-17 18:47:53 +01:00
fork_projects_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
group_descendants_finder.rb Remove code related to object hierarchy in MySQL 2019-07-25 15:35:06 +08:00
group_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
group_labels_finder.rb Add subscribe filter to labels page 2018-10-04 10:24:50 +02:00
group_members_finder.rb Resolve "MembersFinder contains slow database query with OR conditions" 2019-07-29 22:33:57 +00:00
group_projects_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
groups_finder.rb Fix group transfer selection possibilities 2019-04-02 06:49:11 +00:00
issuable_finder.rb Revert "Merge branch '4221-board-milestone-should-persist-any-none-properly-ce' into 'master'" 2019-08-09 09:59:38 +00:00
issues_finder.rb Add improvements to the global search process 2019-05-07 11:08:25 +00:00
joined_groups_finder.rb Applies the CE backport of EE#657 2018-09-24 12:02:01 +01:00
labels_finder.rb Whitelist none method from ActiveRecord::Querying 2018-10-31 15:46:36 -03:00
license_template_finder.rb Backport project template API to CE 2018-10-05 11:34:43 +01:00
members_finder.rb Further remove code branches by database type 2019-07-29 12:47:06 +02:00
merge_request_target_project_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
merge_requests_finder.rb Fix IDE detecting MR from fork branch 2019-04-05 07:29:53 +00:00
milestones_finder.rb Adds milestone search 2019-01-24 18:44:09 +01:00
notes_finder.rb Use NotesFinder in IssuableActions module 2019-08-01 10:42:42 +02:00
pending_todos_finder.rb Clean up ActiveRecord code in TodoService 2018-10-08 15:19:12 +02:00
personal_access_tokens_finder.rb Remove PersonalAccessTokensFinder#find_by method 2018-11-05 11:36:45 +01:00
personal_projects_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
pipeline_schedules_finder.rb Merge branch 'frozen-string-app-finders-graphql' into 'master' 2018-09-13 19:44:31 +00:00
pipelines_finder.rb Rename project's pipelines relation 2018-12-05 14:39:15 +00:00
projects_finder.rb Add improvements to the global search process 2019-05-07 11:08:25 +00:00
README.md
releases_finder.rb ReleasesFinder will always return a relation 2018-12-31 12:05:56 +09:00
runner_jobs_finder.rb Adding order by to list runner jobs api. 2019-07-05 14:24:56 +05:30
snippets_finder.rb Allow all personal snippets to be accessed by API 2019-03-06 09:05:03 +00:00
starred_projects_finder.rb Handle reviewer comments on !24690 2019-08-07 20:49:37 +02:00
tags_finder.rb Enable frozen string in app/graphql + app/finders 2018-09-11 12:15:23 -07:00
template_finder.rb Backport project template API to CE 2018-10-05 11:34:43 +01:00
todos_finder.rb Clean up ActiveRecord code in TodoService 2018-10-08 15:19:12 +02:00
union_finder.rb Added FromUnion to easily select from a UNION 2018-09-17 12:39:43 +02:00
user_finder.rb Make getting a user by the username case insensitive 2018-10-18 09:06:44 +00:00
user_recent_events_finder.rb Resolve "Add new "Overview" tab on user profile page" 2018-10-04 07:55:37 +00:00
users_finder.rb Change sorting options for starrers: name (asc/desc), most/least recent star 2019-08-07 20:49:14 +02:00
users_star_projects_finder.rb Handle reviewer comments on !24690 2019-08-07 20:49:37 +02:00
users_with_pending_todos_finder.rb Clean up ActiveRecord code in TodoService 2018-10-08 15:19:12 +02:00

Finders

This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:

class Project
  def issues_for_user_filtered_by(user, filter)
    # A lot of logic not related to project model itself
  end
end

issues = project.issues_for_user_filtered_by(user, params)

Better use this:

issues = IssuesFinder.new(project, user, filter).execute

It will help keep models thiner.