gitlab-org--gitlab-foss/spec/services/projects
Dmitriy Zaporozhets 5fedc46343 Merge branch 'refactor-create-service-spec' into 'master'
Refactor create service spec

## What does this MR do?
Use let instead instance variables to cache create user operation.

Union some example into one.

## Are there points in the code the reviewer needs to double check?

## Why was this MR needed?
Time before: 1 minute 11.81 seconds

Time after: 52.47 seconds

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- n/a [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- n/a API support added
- Tests
  - n/a Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

See merge request !7609
2016-12-05 18:49:53 +00:00
..
autocomplete_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
create_service_spec.rb Refactor create service spec 2016-11-22 21:23:07 +05:00
destroy_service_spec.rb Make deleting with optimistic locking respect NULL 2016-12-01 16:17:20 +08:00
download_service_spec.rb Get rid of is_image in FileUploader 2016-07-19 18:51:09 +02:00
enable_deploy_key_service_spec.rb Namespace EnableDeployKeyService under Projects 2016-08-08 20:59:51 +02:00
fork_service_spec.rb Enforce the fork_project permission in Projects::CreateService 2016-09-27 13:17:56 +01:00
housekeeping_service_spec.rb Refine Git garbage collection 2016-11-04 14:30:11 +01:00
import_service_spec.rb Check if repository already exists before trying to re-import it 2016-10-28 11:12:48 +02:00
transfer_service_spec.rb Recreates missing group labels when moving project to another group 2016-10-19 14:58:24 -02:00
unlink_fork_service_spec.rb
update_service_spec.rb adds second batch of tests changed to active tense 2016-08-09 15:11:39 +01:00
upload_service_spec.rb Get rid of is_image in FileUploader 2016-07-19 18:51:09 +02:00