kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss

History

Stan Hu c408be48ca Optimize /api/v4/projects endpoint for visibility level Previously when a user requested a list of projects, `Project#public_or_visible_to_user` would search all authorized projects and public/internal projects as well. However, when a user requests a specific `visibility_level` (e.g. private), that should reduce the search space, and we shouldn't need to load public/internal projects. Improves https://gitlab.com/gitlab-org/gitlab-ce/issues/59329		2019-03-27 06:15:33 -05:00
..
admin	add tag filter to admin runners page	2019-02-27 20:19:49 +01:00
autocomplete	use functional style for tags finder	2019-02-27 20:20:24 +01:00
concerns	Ignore ordering when calling find_by on finders	2019-02-20 11:31:06 +00:00
projects	Add project http fetch statistics API	2019-02-27 11:52:35 +01:00
access_requests_finder.rb
applications_finder.rb
awarded_emoji_finder.rb
branches_finder.rb
cluster_ancestors_finder.rb
clusters_finder.rb
contributed_projects_finder.rb	Fix contributed projects finder shown private info	2019-01-31 16:51:16 +01:00
environments_finder.rb
events_finder.rb
fork_projects_finder.rb
group_descendants_finder.rb	Merge branch 'fix-misspellings-app-comments' into 'master'	2019-02-26 12:25:01 +01:00
group_finder.rb
group_labels_finder.rb
group_members_finder.rb
group_projects_finder.rb
groups_finder.rb
issuable_finder.rb	Only count active milestones as started	2019-03-19 14:28:30 +00:00
issues_finder.rb	Merge branch 'filter-confidential-issues' into 'master'	2019-02-26 12:24:39 +01:00
joined_groups_finder.rb
labels_finder.rb
license_template_finder.rb
members_finder.rb
merge_request_target_project_finder.rb
merge_requests_finder.rb	Filter merge requests by target branch	2019-03-09 12:22:58 +00:00
milestones_finder.rb	Adds milestone search	2019-01-24 18:44:09 +01:00
notes_finder.rb
pending_todos_finder.rb
personal_access_tokens_finder.rb
personal_projects_finder.rb
pipeline_schedules_finder.rb
pipelines_finder.rb
projects_finder.rb	Optimize /api/v4/projects endpoint for visibility level	2019-03-27 06:15:33 -05:00
README.md
releases_finder.rb	ReleasesFinder will always return a relation	2018-12-31 12:05:56 +09:00
remote_mirror_finder.rb
runner_jobs_finder.rb
snippets_finder.rb	Allow all personal snippets to be accessed by API	2019-03-06 09:05:03 +00:00
tags_finder.rb
template_finder.rb
todos_finder.rb
union_finder.rb
user_finder.rb
user_recent_events_finder.rb
users_finder.rb
users_with_pending_todos_finder.rb

README.md

Finders

This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:

class Project
  def issues_for_user_filtered_by(user, filter)
    # A lot of logic not related to project model itself
  end
end

issues = project.issues_for_user_filtered_by(user, params)

Better use this:

issues = IssuesFinder.new(project, user, filter).execute

It will help keep models thiner.