kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec
History
Stan Hu 239743345a Fix GitLab Pages not refreshing upon new content 
Due to autoloading and Ruby scoping, the .update file was never being
updated due to this error:

```
NoMethodError: undefined method `pages' for Projects::Settings:Module
        from /opt/gitlab/embedded/service/gitlab-rails/app/services/projects/update_pages_configuration_service.rb:50:in `pages_update_file'
        from /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:157:in `pages_update_file'
        from (irb):6
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/console.rb:110:in `start'
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/console.rb:9:in `start'
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/commands_tasks.rb:68:in `console'
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
        from /opt/gitlab/embedded/lib/ruby/gems/2.3.0/gems/railties-4.2.7.1/lib/rails/commands.rb:17:in `<top (required)>'
        from bin/rails:9:in `require'
```

This error was caught and discarded quietly. This fix exercises this code and fixes the scope problem.

Closes gitlab-com/infrastructure#1058
2017-02-01 23:09:12 +00:00
..
bin
config
controllers Fix 500 error while navigating to the pages_domains 'show' page. 2017-01-31 22:55:33 +00:00
db/production Introduce "stub_env" test helper for safely stubbing environment variables 2017-01-09 18:19:48 +01:00
factories Update comments 2017-01-31 22:53:58 +00:00
features Stub to enable it so that we could test this 2017-01-31 22:55:32 +00:00
finders Use :empty_project where possible in finder specs 2017-01-25 22:31:24 -05:00
fixtures Added support for zip archives in pages 2017-01-31 22:53:57 +00:00
helpers Add tests for nested groups in search service and search helper 2017-01-30 17:33:49 +02:00
initializers Add metric initializer spec 2017-01-24 14:42:57 +00:00
javascripts Merge branch '26282-autosize-js-memory-leak' into 'master' 2017-01-30 21:12:34 +00:00
lib Excluded pages_domains from import/export spec 2017-02-01 22:57:08 +00:00
mailers
migrations fix typo, added relevant spec 2017-01-16 16:11:50 +01:00
models Update validates_hostname to 1.0.6 to fix a bug in parsing hexadecimal-looking domain names 2017-02-01 02:46:07 +00:00
policies Fix build access policies when pipelines are public 2017-01-23 14:49:13 +01:00
presenters/ci More improvements to presenters 2017-01-18 16:38:35 +01:00
requests Update group api doc with full_name and full_path attributes 2017-01-30 17:33:49 +02:00
routing Fix 500 error while navigating to the pages_domains 'show' page. 2017-01-31 22:55:33 +00:00
serializers Return serializable hash from a represented serializer 2017-01-27 13:02:59 +01:00
services Fix GitLab Pages not refreshing upon new content 2017-02-01 23:09:12 +00:00
support Merge branch 'issuable-sidebar-bug' into 'master' 2017-01-27 23:09:00 +00:00
tasks/gitlab Add GitLab Pages 2017-01-31 22:50:39 +00:00
uploaders Don't delete files from spec/fixtures 2017-01-03 15:37:32 +01:00
views Changes after review 2017-01-27 14:27:07 +00:00
workers Move most of PagesWorker logic UpdatePagesService 2017-01-31 22:53:57 +00:00
factories_spec.rb
rails_helper.rb
rake_helper.rb
simplecov_env.rb
spec_helper.rb Add the rspec_profiling gem and documentation to the GitLab development environment 2017-01-27 12:41:16 +00:00
teaspoon_env.rb Add first shared examples to a helper and updated teaspoon_env to allow helper specs to run 2017-01-18 13:33:08 +00:00