279ffe7bff
Reduce overhead of LabelFinder by avoiding #presence call Some users experienced 502 timeouts when viewing group labels. Labels#open_issues_count and Label#open_merge_requests_count were taking a long time to load because they were loading every ActiveRecord of the user-accessible projects into memory. This change modifies so that only the IDs are loaded into memory. Closes #23684 See merge request !7094
94 lines
1.8 KiB
Ruby
94 lines
1.8 KiB
Ruby
class LabelsFinder < UnionFinder
|
|
def initialize(current_user, params = {})
|
|
@current_user = current_user
|
|
@params = params
|
|
end
|
|
|
|
def execute(authorized_only: true)
|
|
@authorized_only = authorized_only
|
|
|
|
items = find_union(label_ids, Label)
|
|
items = with_title(items)
|
|
sort(items)
|
|
end
|
|
|
|
private
|
|
|
|
attr_reader :current_user, :params, :authorized_only
|
|
|
|
def label_ids
|
|
label_ids = []
|
|
|
|
if project
|
|
label_ids << project.group.labels if project.group.present?
|
|
label_ids << project.labels
|
|
else
|
|
label_ids << Label.where(group_id: projects.group_ids)
|
|
label_ids << Label.where(project_id: projects.select(:id))
|
|
end
|
|
|
|
label_ids
|
|
end
|
|
|
|
def sort(items)
|
|
items.reorder(title: :asc)
|
|
end
|
|
|
|
def with_title(items)
|
|
return items if title.nil?
|
|
return items.none if title.blank?
|
|
|
|
items.where(title: title)
|
|
end
|
|
|
|
def group_id
|
|
params[:group_id].presence
|
|
end
|
|
|
|
def project_id
|
|
params[:project_id].presence
|
|
end
|
|
|
|
def projects_ids
|
|
params[:project_ids]
|
|
end
|
|
|
|
def title
|
|
params[:title] || params[:name]
|
|
end
|
|
|
|
def project
|
|
return @project if defined?(@project)
|
|
|
|
if project_id
|
|
@project = find_project
|
|
else
|
|
@project = nil
|
|
end
|
|
|
|
@project
|
|
end
|
|
|
|
def find_project
|
|
if authorized_only
|
|
available_projects.find_by(id: project_id)
|
|
else
|
|
Project.find_by(id: project_id)
|
|
end
|
|
end
|
|
|
|
def projects
|
|
return @projects if defined?(@projects)
|
|
|
|
@projects = authorized_only ? available_projects : Project.all
|
|
@projects = @projects.in_namespace(group_id) if group_id
|
|
@projects = @projects.where(id: projects_ids) if projects_ids
|
|
@projects = @projects.reorder(nil)
|
|
|
|
@projects
|
|
end
|
|
|
|
def available_projects
|
|
@available_projects ||= ProjectsFinder.new.execute(current_user)
|
|
end
|
|
end
|