gitlab-org--gitlab-foss/app/helpers
Rémy Coutable 140a706e96 Merge branch 'retrieve-mr-closes-issues-just-when-required' into 'master'
Avoid calculation of closes_issues.

## What does this MR do?

Avoid unneeded calls to MR closes issues

## Are there points in the code the reviewer needs to double check?

I'm not sure if calling this method from a view is a good practice, but I cannot see another simple way of avoiding this problem. In case we want to avoid this in the controller we need to specify the action, format and status of the merge request, because in that case we know that the `_open` partial will render. We could add some lazy evaluation but it not a thing I see in use along the app but feedback is welcome

## What are the relevant issue numbers?

#14202 , #19490

## Does this MR meet the acceptance criteria?

- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- ~~[ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~
- ~~[ ] API support added~~
- Tests
  - ~~[ ] Added for this feature/bug~~
  - [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !5140
2016-07-08 16:13:08 +00:00
..
appearances_helper.rb Added blank state to issues 2016-07-05 09:06:38 +01:00
application_helper.rb Style diff and blob file headers the same way 2016-07-06 18:50:59 -04:00
application_settings_helper.rb Use keyword arguments for boolean values and use `span` instead of `a` for clone "button" 2016-07-05 16:54:22 -05:00
auth_helper.rb
blob_helper.rb add custom highlighting via .gitattributes 2016-06-27 14:17:49 -07:00
branches_helper.rb Revert back to not defining a default Git access protocol. 2016-07-05 16:54:22 -05:00
broadcast_messages_helper.rb
button_helper.rb Use keyword arguments for boolean values and use `span` instead of `a` for clone "button" 2016-07-05 16:54:22 -05:00
ci_status_helper.rb
commits_helper.rb
compare_helper.rb
dashboard_helper.rb
diff_helper.rb Remove duplication, unused methods, and some other style things 2016-07-06 19:29:41 -04:00
dropdowns_helper.rb Revert "Revert "Merge branch 'issue_3946' into 'master' "" 2016-07-07 23:48:02 -04:00
emails_helper.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
events_helper.rb
explore_helper.rb
external_wiki_helper.rb
form_helper.rb
git_helper.rb
gitlab_markdown_helper.rb
gitlab_routing_helper.rb
graph_helper.rb
groups_helper.rb
icons_helper.rb
import_helper.rb
issuables_helper.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
issues_helper.rb Add emoji.rb in lib/gitlab instead of using the gitlab_emoji gem. 2016-06-29 14:53:09 -06:00
javascript_helper.rb
kerberos_spnego_helper.rb Groundwork for Kerberos SPNEGO (EE feature) 2016-07-01 11:46:56 +02:00
labels_helper.rb
members_helper.rb New :request_access ability to replace a ugly helper 2016-07-05 14:35:26 +02:00
merge_requests_helper.rb Merge branch 'retrieve-mr-closes-issues-just-when-required' into 'master' 2016-07-08 16:13:08 +00:00
milestones_helper.rb
namespaces_helper.rb
nav_helper.rb
notes_helper.rb Display new diff notes and allow creation through the web interface 2016-07-06 18:51:00 -04:00
notifications_helper.rb merge master into issue_3359_3 2016-06-29 11:04:18 -03:00
page_layout_helper.rb Enable Style/SpaceAfterComma Rubocop cop 2016-06-29 15:23:44 +02:00
preferences_helper.rb
projects_helper.rb Show last push widget in upstream after push to fork 2016-07-06 12:58:57 -05:00
runners_helper.rb
search_helper.rb Enable Style/EmptyLines cop, remove redundant ones 2016-07-01 21:56:17 +02:00
selects_helper.rb
snippets_helper.rb
sorting_helper.rb
submodule_helper.rb
tab_helper.rb
tags_helper.rb
time_helper.rb Change 3600 to 1.hour 2016-07-07 16:48:10 -05:00
todos_helper.rb
tree_helper.rb
triggers_helper.rb
version_check_helper.rb
visibility_level_helper.rb
workhorse_helper.rb Add send_git_patch helper 2016-07-06 18:51:01 -04:00