kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
gitlab-org--gitlab-foss/spec/finders
History
Patrick Derichs 932a9a0c77 Use NotesFinder to fetch notes on API and Controllers 
Fix missing iid query on NotesFinder

Changed parameters of find_noteable, 
so changes across a few files were needed.
MergeRequest also requires iid instead of id query

Make NotesFinder fail with RecordNotFound again

Add specs for target_iid

Using RSpec tablesyntax for target_iid specs

Revert "Using RSpec tablesyntax for target_iid specs"

This reverts commit ba45c7f569a.

Allow find_by! here

Fix variable name

Add readable check

Revert "Add readable check"

This reverts commit 9e3a1a7aa39.

Remove unnecessary assignment

Add required changes for EE

Fix parameter count

Reduce code duplication by extracting a noteable module method

The call to find_noteable was redundant so
multiple files and lines have changed in that
commit to use the newly introduced module
method `noteable`.

Replace casecmp with include check

Add parent_type parameter


Revert "Reduce code duplication by extracting
a noteable module method"

This reverts commit 8c0923babff16.

Method is no longer needed

Check whether noteable can be read by user
 		2019-06-19 10:56:55 +02:00
..
admin add tag filter to admin runners page 2019-02-27 20:19:49 +01:00
autocomplete Only show in autocomplete when author active 2019-04-12 14:58:42 +08:00
clusters Move file one folder level up to avoid namespace conflict 2019-06-03 15:42:06 +01:00
concerns Ignore ordering when calling find_by on finders 2019-02-20 11:31:06 +00:00
projects/serverless Adapt functions to work for external Knative 2019-05-29 11:21:53 +01:00
access_requests_finder_spec.rb Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
applications_finder_spec.rb Code styling 2018-10-18 10:08:23 +09:00
awarded_emoji_finder_spec.rb Refactor AutocompleteController 2018-08-20 13:53:00 +02:00
branches_finder_spec.rb Feature improved branch filter sorting 2018-10-11 14:25:30 +00:00
cluster_ancestors_finder_spec.rb Allow projects to use instance level clusters 2019-05-07 08:37:03 +12:00
clusters_finder_spec.rb
…
contributed_projects_finder_spec.rb Fix contributed projects finder shown private info 2019-01-31 16:51:16 +01:00
environments_finder_spec.rb Squashed commit of the following: 2018-11-06 10:54:27 +09:00
events_finder_spec.rb Hide confidential events in ruby 2018-12-17 18:47:53 +01:00
fork_projects_finder_spec.rb Hashed Storage is enabled by default on new installations 2019-06-17 20:35:22 +02:00
group_descendants_finder_spec.rb Fix default sorting for subgroups and projects list 2018-11-14 14:47:09 +01:00
group_labels_finder_spec.rb Add subscribe filter to labels page 2018-10-04 10:24:50 +02:00
group_members_finder_spec.rb Resolve "Can add an existing group member into a group project with new permissions but permissions are not overridden" 2018-12-06 13:15:29 +00:00
group_projects_finder_spec.rb [CE] Reduce differences with EE in group_projects_finder_spec.rb 2019-03-21 17:31:41 +01:00
groups_finder_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
issues_finder_spec.rb Remove some deprecated code 2019-06-07 14:32:31 +03:00
joined_groups_finder_spec.rb Resolve "Rename the `Master` role to `Maintainer`" Backend 2018-07-11 14:36:08 +00:00
labels_finder_spec.rb Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE 2019-04-09 15:38:58 +00:00
license_template_finder_spec.rb Backport project template API to CE 2018-10-05 11:34:43 +01:00
members_finder_spec.rb Removes duplicated members from api/projects/:id/members/all 2019-05-27 15:40:56 +02:00
merge_request_target_project_finder_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
merge_requests_finder_spec.rb Add improvements to the global search process 2019-05-07 11:08:25 +00:00
milestones_finder_spec.rb Autocorrect with RSpec/ExampleWording cop 2019-04-05 08:43:27 +00:00
notes_finder_spec.rb Use NotesFinder to fetch notes on API and Controllers 2019-06-19 10:56:55 +02:00
pending_todos_finder_spec.rb Rails5: Passing a class as a value in an Active Record query is deprecated 2018-11-17 16:14:36 +01:00
personal_access_tokens_finder_spec.rb Remove PersonalAccessTokensFinder#find_by method 2018-11-05 11:36:45 +01:00
personal_projects_finder_spec.rb Updates from `rubocop -a` 2018-07-09 21:13:08 +08:00
pipeline_schedules_finder_spec.rb Eliminate duplicated words 2018-11-22 01:01:23 +09:00
pipelines_finder_spec.rb preventing blocked users and their PipelineSchdules from creating new Pipelines 2019-06-04 20:25:26 -05:00
projects_finder_spec.rb Enable the Layout/ExtraSpacing cop 2019-01-24 13:05:45 +01:00
releases_finder_spec.rb ReleasesFinder will always return a relation 2018-12-31 12:05:56 +09:00
runner_jobs_finder_spec.rb Refactor validations and make runner factory by default to be instance-wide runner 2018-05-31 10:56:07 +02:00
snippets_finder_spec.rb Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE 2019-04-09 15:38:58 +00:00
tags_finder_spec.rb
…
template_finder_spec.rb Backport project template API to CE 2018-10-05 11:34:43 +01:00
todos_finder_spec.rb Move Contribution Analytics related spec in spec/features/groups/group_page_with_external_authorization_service_spec to EE 2019-04-09 15:38:58 +00:00
user_finder_spec.rb Make getting a user by the username case insensitive 2018-10-18 09:06:44 +00:00
user_recent_events_finder_spec.rb Hide confidential events in ruby 2018-12-17 18:47:53 +01:00
users_finder_spec.rb [CE] Reduce differences with EE in users_finder_spec.rb 2019-03-21 17:33:51 +01:00
users_with_pending_todos_finder_spec.rb Clean up ActiveRecord code in TodoService 2018-10-08 15:19:12 +02:00