a9827e0e18
When using the members/all api the same user was returned multiple times when he was a member of the project/group and also of one of the ancestor groups. Now the member is returned only once giving priority to the membership on the project and maintaining the same behaviour of the members UI. |
||
|---|---|---|
| .. | ||
| admin | ||
| autocomplete | ||
| concerns | ||
| projects | ||
| README.md | ||
| access_requests_finder.rb | ||
| applications_finder.rb | ||
| awarded_emoji_finder.rb | ||
| branches_finder.rb | ||
| cluster_ancestors_finder.rb | ||
| clusters_finder.rb | ||
| contributed_projects_finder.rb | ||
| environments_finder.rb | ||
| events_finder.rb | ||
| fork_projects_finder.rb | ||
| group_descendants_finder.rb | ||
| group_finder.rb | ||
| group_labels_finder.rb | ||
| group_members_finder.rb | ||
| group_projects_finder.rb | ||
| groups_finder.rb | ||
| issuable_finder.rb | ||
| issues_finder.rb | ||
| joined_groups_finder.rb | ||
| labels_finder.rb | ||
| license_template_finder.rb | ||
| members_finder.rb | ||
| merge_request_target_project_finder.rb | ||
| merge_requests_finder.rb | ||
| milestones_finder.rb | ||
| notes_finder.rb | ||
| pending_todos_finder.rb | ||
| personal_access_tokens_finder.rb | ||
| personal_projects_finder.rb | ||
| pipeline_schedules_finder.rb | ||
| pipelines_finder.rb | ||
| projects_finder.rb | ||
| releases_finder.rb | ||
| remote_mirror_finder.rb | ||
| runner_jobs_finder.rb | ||
| snippets_finder.rb | ||
| tags_finder.rb | ||
| template_finder.rb | ||
| todos_finder.rb | ||
| union_finder.rb | ||
| user_finder.rb | ||
| user_recent_events_finder.rb | ||
| users_finder.rb | ||
| users_with_pending_todos_finder.rb | ||
README.md
Finders
This type of classes responsible for collection items based on different conditions. To prevent lookup methods in models like this:
class Project
def issues_for_user_filtered_by(user, filter)
# A lot of logic not related to project model itself
end
end
issues = project.issues_for_user_filtered_by(user, params)
Better use this:
issues = IssuesFinder.new(project, user, filter).execute
It will help keep models thiner.