509c9ad000
Previously it seems that PRs were responded to within 1-3 days, however this has not been the case for about a year so I'm udating the relevant section of this guide in order to set more realistic expectations. This is mainly so people do not get discouraged when they see we haven't responded after a few days.
2.9 KiB
Contributing
We love pull requests. Here's a quick guide:
-
Fork the repo.
-
Create your feature branch (
git checkout -b my-new-feature) -
Update CHANGELOG.md with a brief description of your changes under the
unreleasedheading. -
Add/Update tests were appropriate
-
Commit your changes (
git commit -am 'Added some feature') -
Push to the branch (
git push origin my-new-feature) -
Create new Pull Request
At this point you're waiting on us. We are not super fast at responding, but we will do our best to get to your PR as soon as time permits. We may suggest some changes, improvements or alternatives.
Some things that will increase the chance that your pull request is accepted is to follow the practices described on Ruby style guide, Rails style guide and Better Specs.
Specs
To run all the specs in all gemfiles just run:
$ rake
To run specs of a single gemfile run:
$ appraisal rails-3.2 rake
If you want to run a specific spec in a gemfile run:
$ appraisal rails-3.2 rspec spec/colors_spec.rb
Contributor Rolecall
Special thanks goes to awesome team of contributors, namely:
- 6fusion.com -- https://github.com/6fusion
- Adam Doppelt -- https://github.com/gurgeous
- Andrew O'Brien -- https://github.com/AndrewO
- Andrew Horsman -- https://github.com/basicxman
- Barry Allard -- https://github.com/steakknife
- Benoit Daloze -- http://github.com/eregon
- Brandon Zylstra -- https://github.com/brandondrew
- Dan Lynn -- https://github.com/danlynn
- Daniel Johnson -- https://github.com/adhd360
- Daniel Bretoi -- http://github.com/danielb2
- Eloy Duran -- http://github.com/alloy
- Elpizo Choi -- https://github.com/fuJiin
- Evan Senter -- https://github.com/evansenter
- George . -- https://github.com/gardelea
- Greg Weber -- https://github.com/gregwebs
- Jan Vansteenkiste -- https://github.com/vStone
- Jeff Felchner -- https://github.com/jfelchner
- Jonathan Davies -- send your Github URL ;-)
- Kevin Olbrich -- https://github.com/olbrich
- Matthew Schulkind -- https://github.com/mschulkind
- Mike McQuaid -- https://github.com/mikemcquaid
- Nami-Doc -- https://github.com/Nami-Doc
- Nicolas Viennot -- https://github.com/nviennot
- Nikolaj Nikolajsen -- https://github.com/nikolajsen
- Richard Hall -- https://github.com/richardardrichard
- Ryan Schlesinger -- https://github.com/ryansch
- Scott Hyndman -- https://github.com/shyndman
- Sean Gallagher -- http://github.com/torandu
- Stephan Hagemann -- https://github.com/shageman
- Tim Harper -- http://github.com/timcharper
- Tobias Crawley -- http://github.com/tobias
- Thibaut Barrère -- https://github.com/thbar
- Trevor Wennblom -- https://github.com/trevor
- vfrride -- https://github.com/vfrride
- Viktar Basharymau -- https://github.com/DNNX