mirror of
https://github.com/rails/rails.git
synced 2022-11-09 12:12:34 -05:00
b63d532f1e
So this bug is kinda funky. The code path is basically "if we weren't passed an
instance of the class we compose to, and we have a converter, call that".
Ignoring the hash case for a moment, everything after that was roughly intended
to be the "else" clause, meaning that we are expected to have an instance of
the class we compose to. Really, we should be blowing up in that case, as we
can give a much better error message than what they user will likely get (e.g.
`NameError: No method first for String` or something). Still, Ruby is duck
typed, so if the object you're assigning responds to the same methods as the
type you compose to, knock yourself out.
The hash case was added in 36e9be8 to remove a bunch of special cased code from
multiparameter assignment. I wrongly assumed that the only time we'd get a hash
there is in that case. Multiparameter assignment will construct a very specific
hash though, where the keys are integers, and we will have a set of keys
covering `1..part.size` exactly. I'm pretty sure this could actually be passed
around as an array, but that's a different story. Really I should convert this
to something like `class MultiParameterAssignment < Hash; end`, which I might
do soon. However for a change that I'm willing to backport to 4-2-stable, this
is what I want to go with for the time being.
Fixes #25978
117 lines
3 KiB
Markdown
117 lines
3 KiB
Markdown
* Hashes can once again be passed to setters of `composed_of`, if all of the
|
|
mapping methods are methods implemented on `Hash`.
|
|
|
|
Fixes #25978.
|
|
|
|
*Sean Griffin*
|
|
|
|
* Fix the SELECT statement in `#table_comment` for MySQL.
|
|
|
|
*Takeshi Akima*
|
|
|
|
* Virtual attributes will no longer raise when read on models loaded from the
|
|
database
|
|
|
|
*Sean Griffin*
|
|
|
|
* Support calling the method `merge` in `scope`'s lambda.
|
|
|
|
*Yasuhiro Sugino*
|
|
|
|
* Fixes multi-parameter attributes conversion with invalid params.
|
|
|
|
*Hiroyuki Ishii*
|
|
|
|
* Add newline between each migration in `structure.sql`.
|
|
|
|
Keeps schema migration inserts as a single commit, but allows for easier
|
|
git diffing.
|
|
|
|
Fixes #25504.
|
|
|
|
*Grey Baker*, *Norberto Lopes*
|
|
|
|
* The flag `error_on_ignored_order_or_limit` has been deprecated in favor of
|
|
the current `error_on_ignored_order`.
|
|
|
|
*Xavier Noria*
|
|
|
|
* Batch processing methods support `limit`:
|
|
|
|
Post.limit(10_000).find_each do |post|
|
|
# ...
|
|
end
|
|
|
|
It also works in `find_in_batches` and `in_batches`.
|
|
|
|
*Xavier Noria*
|
|
|
|
* Using `group` with an attribute that has a custom type will properly cast
|
|
the hash keys after calling a calculation method like `count`. Fixes #25595.
|
|
|
|
*Sean Griffin*
|
|
|
|
* Fix the generated `#to_param` method to use `omission: ''` so that
|
|
the resulting output is actually up to 20 characters, not
|
|
effectively 17 to leave room for the default "...".
|
|
Also call `#parameterize` before `#truncate` and make the
|
|
`separator: /-/` to maximize the information included in the
|
|
output.
|
|
|
|
Fixes #23635.
|
|
|
|
*Rob Biedenharn*
|
|
|
|
* Ensure concurrent invocations of the connection reaper cannot allocate the
|
|
same connection to two threads.
|
|
|
|
Fixes #25585.
|
|
|
|
*Matthew Draper*
|
|
|
|
* Inspecting an object with an associated array of over 10 elements no longer
|
|
truncates the array, preventing `inspect` from looping infinitely in some
|
|
cases.
|
|
|
|
*Kevin McPhillips*
|
|
|
|
* Removed the unused methods `ActiveRecord::Base.connection_id` and
|
|
`ActiveRecord::Base.connection_id=`.
|
|
|
|
*Sean Griffin*
|
|
|
|
* Ensure hashes can be assigned to attributes created using `composed_of`.
|
|
Fixes #25210.
|
|
|
|
*Sean Griffin*
|
|
|
|
* Fix logging edge case where if an attribute was of the binary type and
|
|
was provided as a Hash.
|
|
|
|
*Jon Moss*
|
|
|
|
* Handle JSON deserialization correctly if the column default from database
|
|
adapter returns `''` instead of `nil`.
|
|
|
|
*Johannes Opper*
|
|
|
|
* Introduce `ActiveRecord::TransactionSerializationError` for catching
|
|
transaction serialization failures or deadlocks.
|
|
|
|
*Erol Fornoles*
|
|
|
|
* PostgreSQL: Fix db:structure:load silent failure on SQL error.
|
|
|
|
The command line flag `-v ON_ERROR_STOP=1` should be used
|
|
when invoking `psql` to make sure errors are not suppressed.
|
|
|
|
Example:
|
|
|
|
psql -v ON_ERROR_STOP=1 -q -f awesome-file.sql my-app-db
|
|
|
|
Fixes #23818.
|
|
|
|
*Ralin Chimev*
|
|
|
|
|
|
Please check [5-0-stable](https://github.com/rails/rails/blob/5-0-stable/activerecord/CHANGELOG.md) for previous changes.
|