rails--rails/actionpack/CHANGELOG.md at e03add224899e0a10e7cfa28c09e68c8b9c920ed

kotovalexarian-likes-github/rails--rails

mirror of https://github.com/rails/rails.git synced 2022-11-09 12:12:34 -05:00

Aaron Kromer 20543c0496 Add implicit to path conversion to uploaded file (#28676 )

* Add implicit to path conversion to uploaded file

Ruby has a few implicit conversion protocols (e.g. `to_hash`, `to_str`,
`to_path`, etc.). These are considered implicit conversion protocols
because in certain instances Ruby (MRI core objects) will check if an
argument responds to the appropriate protocol and automatically convert
it when it does; this is why you can provide a `Pathname` instance into
`File.read` without having to explicitly call `to_s`.

```ruby
a_file_path = 'some/path/file.ext'
File.write a_file_path, 'String Path Content'
File.read a_file_path

a_pathname = Pathname(a_file_path)
File.write core_file, 'Pathname Content'
File.read a_file_path

core_file = File.new(a_pathname)
File.write core_file, 'File Content'
File.read core_file

tmp_file = Tempfile.new('example')
File.write tmp_file, 'Tempfile Content'
File.read tmp_file
```

So how does an uploaded file work in such cases?

```ruby
tmp_file = Tempfile.new('example')
File.write tmp_file, 'Uploaded Content'
uploaded_file = ActionDispatch::Http::UploadedFile.new(tempfile: tmp_file)
File.read uploaded_file
```

It fails with a `TypeError`:

    no implicit conversion of ActionDispatch::Http::UploadedFile into String

In order to make an uploaded file work it must be explicitly converted
to a file path using `path`.

```ruby
File.read uploaded_file.path
```

This requires any code that expects path/file like objects to either
special case an uploaded file, re-implement the path conversion protocol
to use `path`, or forces the developer to explicitly cast uploaded files
to paths. This last option can sometimes be difficult to do when such
calls are deep within the inner workings of libraries.

Since an uploaded file already has a path it makes sense to implement
the implicit "path" conversion protocol (just like `File` and
`Tempfile`). This change allows uploaded file content to be treated more
closely to regular file content, without requiring any special case
handling or explicit conversion for common file utilities.

* Note uploaded file path delegation in CHANGELOG

2018-07-22 10:00:40 +02:00

1.9 KiB

Raw Blame History

ActionDispatch::Http::UploadedFile now delegates to_path to its tempfile.

This allows uploaded file objects to be passed directly to File.read without raising a TypeError:
```
uploaded_file = ActionDispatch::Http::UploadedFile.new(tempfile: tmp_file)
File.read(uploaded_file)
```
Aaron Kromer
Pass along arguments to underlying get method in follow_redirect!

Now all arguments passed to follow_redirect! are passed to the underlying get method. This for example allows to set custom headers for the redirection request to the server.
```
follow_redirect!(params: { foo: :bar })
```
Remo Fritzsche
Introduce a new error page to when the implicit render page is accessed in the browser.

Now instead of showing an error page that with exception and backtraces we now show only one informative page.

Vinicius Stock
Introduce ActionDispatch::DebugExceptions.register_interceptor

Exception aware plugin authors can use the newly introduced .register_interceptor method to get the processed exception, instead of monkey patching DebugExceptions.
```
ActionDispatch::DebugExceptions.register_interceptor do |request, exception|
  HypoteticalPlugin.capture_exception(request, exception)
end
```
Genadi Samokovarov
Output only one Content-Security-Policy nonce header value per request.

Fixes #32597.

Andrey Novikov, Andrew White
Move default headers configuration into their own module that can be included in controllers.

Kevin Deisz
Add method dig to session.

claudiob, Takumi Shotoku
Controller level force_ssl has been deprecated in favor of config.force_ssl.

Derek Prior
Rails 6 requires Ruby 2.4.1 or newer.

Jeremy Daer

Please check 5-2-stable for previous changes.

1.9 KiB Raw Blame History

1.9 KiB

Raw Blame History