Ryuta Kamizono bdaf273cbe Avoid implicit create_with for StiClass.all ... Regardless of whether doing implicit `create_with` or not, `sti_name` is set by `ensure_proper_type`. 11f54e12b9/activerecord/lib/active_record/inheritance.rb (L289-L304) The purpose of the `create_with` is to suppress/override `type_condition`, since `type_condition` will be an array of all sti subclass names for `scope_for_create`, it is not desired behavior for `scope_for_create`, and it will cause `find_sti_class` to fail. That undesired behavior was derived from `In` arel node was accidentally a subclass of `Equality` node, IMHO it is considered as almost a bug. But someone depends on the behavior for now (see also #39288). Unfortunately that implicit `create_with` had an unwanted side effect to fail `or` with STI subclass relation #39956. This changes a way to suppress/override `type_condition`, from doing implicit `create_with` to excepting `type_condition` in `scope_for_create`, to fix the `or` issue #39956.		2020-08-01 23:02:50 +09:00
..
admin	Update prefix and allow suffix options for store accessors	2018-06-12 07:10:09 -07:00
autoloadable
publisher
account.rb	Ensure Contextual validations fire on associations	2019-10-04 12:17:53 +01:00
admin.rb
aircraft.rb
arunit2_model.rb
author.rb	Revert "Merge pull request #39613 from kamipo/where_with_custom_operator"	2020-07-17 21:05:48 +09:00
auto_id.rb
binary.rb
bird.rb	Revert "Merge pull request #35186 from kamipo/fix_leaking_scope_on_relation_create"	2019-02-15 12:06:45 +09:00
book.rb	Fix pluck to correctly type cast same column names and association columns	2020-05-13 20:24:42 +09:00
boolean.rb
bulb.rb	Allow extra scoping in callbacks when create on association relation	2020-04-10 16:10:49 +09:00
cake_designer.rb
car.rb	Fix unscoping association scope on joins not to raise an error	2020-04-16 00:34:41 +09:00
carrier.rb
cat.rb
categorization.rb
category.rb	Fix reset of the source association when through association is loaded	2019-02-20 13:48:51 +02:00
chef.rb
citation.rb	Eager loading/preloading should be worked regardless of large number of records	2018-09-12 01:11:38 +09:00
club.rb	Enable Layout/EmptyLinesAroundAccessModifier cop	2019-06-13 12:00:45 +09:00
college.rb	Removes require_dependency from the AR test suite	2020-05-06 09:01:38 +02:00
column.rb
column_name.rb
comment.rb	Check that entire collection has been loaded before short circuiting	2019-11-19 15:32:36 -06:00
company.rb	has_attribute? should be aware of attribute aliases	2020-06-03 00:59:35 +09:00
company_in_module.rb	Enable Layout/EmptyLinesAroundAccessModifier cop	2019-06-13 12:00:45 +09:00
computer.rb
contact.rb	Deduplicate various Active Record schema cache structures	2019-06-03 13:31:42 +02:00
content.rb
contract.rb	Fix pluck and select with custom attributes	2019-02-13 02:47:46 +09:00
country.rb	create_table with :primary_key option has no effect if id: false is given	2018-10-27 22:57:16 +09:00
course.rb	Removes require_dependency from the AR test suite	2020-05-06 09:01:38 +02:00
customer.rb
customer_carrier.rb
dashboard.rb	Ensure custom PK types are casted in through reflection queries	2019-08-07 16:27:33 -04:00
default.rb
department.rb
developer.rb	Support where with comparison operators (>, >=, <, and <=)	2020-07-06 10:24:48 +09:00
dog.rb
dog_lover.rb
doubloon.rb
drink_designer.rb	Polymorphic has_one touch: Reset association cache result after create transaction	2019-07-31 05:59:23 +02:00
edge.rb
electron.rb
engine.rb
entrant.rb
entry.rb	Add delegated type to Active Record (#39341)	2020-05-23 15:14:40 -07:00
essay.rb
event.rb
eye.rb
face.rb	Fix comment for "broken" inverse_of associations [ci skip]	2019-05-28 18:22:22 +02:00
family.rb
family_tree.rb
friendship.rb
frog.rb
guid.rb
guitar.rb
hotel.rb
image.rb	:polymorphic, :as, and :foreign_type are valid for polymorphic association	2019-11-10 10:54:58 +09:00
interest.rb	Don't run callbacks on has_many inverse add	2019-10-10 16:18:13 -04:00
invoice.rb
item.rb
job.rb
joke.rb
keyboard.rb
legacy_thing.rb
lesson.rb
line_item.rb
liquid.rb
man.rb	Don't run callbacks on has_many inverse add	2019-10-10 16:18:13 -04:00
matey.rb
measurement.rb	This PR adds support to retrieve partitioned indexes when asking for	2020-02-06 07:36:44 +02:00
member.rb	Ensure to calculate column aliases after all table aliases are constructed	2018-06-19 22:21:51 +09:00
member_detail.rb
member_type.rb
membership.rb
mentor.rb
message.rb	Add delegated type to Active Record (#39341)	2020-05-23 15:14:40 -07:00
minimalistic.rb
minivan.rb
mixed_case_monkey.rb
molecule.rb
mouse.rb	Don't validate non dirty association targets	2019-07-15 18:21:20 +01:00
movie.rb
node.rb
non_primary_key.rb
notification.rb
numeric_data.rb
order.rb
organization.rb
other_dog.rb	Removes require_dependency from the AR test suite	2020-05-06 09:01:38 +02:00
owner.rb
parrot.rb	Exercise HABTM fixtures with foreign key constraints	2018-10-30 11:08:41 +09:00
person.rb	Enable Layout/EmptyLinesAroundAccessModifier cop	2019-06-13 12:00:45 +09:00
personal_legacy_thing.rb
pet.rb
pet_treasure.rb
pirate.rb	Ensure Contextual validations fire on associations	2019-10-04 12:17:53 +01:00
possession.rb
post.rb	Avoid implicit create_with for StiClass.all	2020-08-01 23:02:50 +09:00
price_estimate.rb	Fix numericality validator not to be affected by custom getter	2018-08-13 23:28:46 +09:00
professor.rb	Removes require_dependency from the AR test suite	2020-05-06 09:01:38 +02:00
project.rb
publisher.rb
randomly_named_c1.rb
rating.rb	Maintain extra joins for string or complex arel conditions	2019-10-04 13:29:18 +09:00
reader.rb
recipe.rb
record.rb
reference.rb	Ensure StatementCache#execute never raises RangeError	2019-01-18 16:01:14 +09:00
reply.rb	Allow attribute aliases for validates_uniqueness_of	2020-06-01 22:44:39 +09:00
section.rb	Fix circular autosave: true	2018-07-23 14:53:27 -07:00
seminar.rb	Fix circular autosave: true	2018-07-23 14:53:27 -07:00
session.rb	Fix circular autosave: true	2018-07-23 14:53:27 -07:00
ship.rb	Ensure Contextual validations fire on associations	2019-10-04 12:17:53 +01:00
ship_part.rb
shop.rb
shop_account.rb
speedometer.rb
sponsor.rb
squeak.rb	Don't validate non dirty association targets	2019-07-15 18:21:20 +01:00
string_key_object.rb
student.rb
subscriber.rb	Ensure custom PK types are casted in through reflection queries	2019-08-07 16:27:33 -04:00
subscription.rb	Ensure custom PK types are casted in through reflection queries	2019-08-07 16:27:33 -04:00
tag.rb
tagging.rb
task.rb
topic.rb	Allow define scope for Ruby reserved keywords	2020-05-14 21:39:39 +09:00
toy.rb
traffic_light.rb
treasure.rb
treaty.rb	create_table with :primary_key option has no effect if id: false is given	2018-10-27 22:57:16 +09:00
tree.rb
tuning_peg.rb
tyre.rb
user.rb	Allow token length configuration for has_secure_token method	2019-04-09 17:25:50 -04:00
uuid_child.rb
uuid_item.rb
uuid_parent.rb
vegetables.rb
vertex.rb
warehouse_thing.rb
wheel.rb	Fix touch option to behave consistently with Persistence#touch method	2018-06-18 19:08:41 +09:00
without_table.rb
zine.rb