kotovalexarian-likes-github
/
thoughtbot--shoulda-matchers
mirror of https://github.com/thoughtbot/shoulda-matchers.git
1
0
Fork 0
Code Releases Activity
thoughtbot--shoulda-matchers/.rubocop.yml

221 lines
4.6 KiB
YAML
Raw Normal View History

Bring in Rails cops using rubocop-rails After installing Rubocop 0.71, I received this warning: Rails cops will be removed from RuboCop 0.72. Use the `rubocop-rails` gem instead. This commit follows these instructions. [ci skip]
2019-06-08 03:57:40 +00:00
require: rubocop-rails
Update Rubocop settings
2018-01-24 06:51:35 +00:00
AllCops:
TargetRubyVersion: 2.4
Tweak Rubocop configuration
2019-06-09 07:56:32 +00:00
Layout/AlignArguments:
EnforcedStyle: with_fixed_indentation
Update Rubocop settings
2018-01-24 06:51:35 +00:00
Layout/AlignParameters:
Configure Hound * Prefer single quotes to double quotes * Align method parameters with fixed indentation [ci skip]
2015-01-04 01:19:00 +00:00
EnforcedStyle: with_fixed_indentation
Update Rubocop & Rubocop config
2019-05-30 06:28:00 +00:00
Layout/CommentIndentation:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Layout/ConditionPosition:
Enabled: false
Layout/DotPosition:
EnforcedStyle: trailing
Update Rubocop & Rubocop config
2019-05-30 06:28:00 +00:00
Layout/EmptyLineBetweenDefs:
AllowAdjacentOneLineDefs: true
Layout/IndentHeredoc:
Enabled: false
Update Rubocop config [ci skip]
2019-01-30 01:49:38 +00:00
Layout/MultilineMethodCallIndentation:
EnforcedStyle: indented
Fix warnings and linter violations in inclusion matcher
2019-06-13 06:28:49 +00:00
Layout/SpaceInsideBlockBraces:
Enabled: false
Update Rubocop & Rubocop config
2019-05-30 06:28:00 +00:00
Layout/SpaceInLambdaLiteral:
EnforcedStyle: require_space
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Lint/AmbiguousOperator:
Enabled: false
Lint/AmbiguousRegexpLiteral:
Enabled: false
Lint/AssignmentInCondition:
Enabled: false
Lint/DeprecatedClassMethods:
Enabled: false
Lint/ElseLayout:
Enabled: false
Update Rubocop & Rubocop config
2019-05-30 06:28:00 +00:00
Lint/FlipFlop:
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Enabled: false
Update Rubocop & Rubocop config
2019-05-30 06:28:00 +00:00
Lint/HandleExceptions:
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Enabled: false
Lint/LiteralInInterpolation:
Enabled: false
Lint/Loop:
Enabled: false
Lint/ParenthesesAsGroupedExpression:
Enabled: false
Lint/RequireParentheses:
Enabled: false
Turn off more Rubocop checks
2019-07-07 02:25:27 +00:00
Lint/SafeNavigationChain:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Lint/UnderscorePrefixedVariableName:
Enabled: false
Lint/Void:
Enabled: false
Update Rubocop & Rubocop config
2019-05-30 06:28:00 +00:00
Metrics/AbcSize:
Max: 25
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Metrics/BlockLength:
Enabled: false
Metrics/ClassLength:
Enabled: false
Metrics/LineLength:
IgnoredPatterns:
Update Rubocop & Rubocop config
2019-05-30 06:28:00 +00:00
- "^[ ]*#.+$"
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
- "^[ ]*describe.+$"
- "^[ ]*context.+$"
- "^[ ]*shared_context.+$"
- "^[ ]*shared_examples_for.+$"
- "^[ ]*it.+$"
Add failing tests for issue 1146
2019-01-30 05:58:03 +00:00
- "^[ ]*'.+?' => '.+?',?$"
- "^[ ]*\".+?\" => \".+?\",?$"
Update Rubocop config [ci skip]
2019-01-30 01:49:38 +00:00
Metrics/MethodLength:
Max: 30
Update Rubocop & Rubocop config
2019-05-30 06:28:00 +00:00
Metrics/ParameterLists:
CountKeywordArgs: false
Metrics/PerceivedComplexity:
Max: 10
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Naming/AccessorMethodName:
Enabled: false
Naming/AsciiIdentifiers:
Enabled: false
Naming/BinaryOperatorParameterName:
Enabled: false
Tweak Rubocop config
2019-03-17 22:22:43 +00:00
Naming/MemoizedInstanceVariableName:
EnforcedStyleForLeadingUnderscores: required
Naming/PredicateName:
Enabled: false
Tweak Rubocop configuration
2019-06-09 07:56:32 +00:00
Style/BlockDelimiters:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Style/ClassVars:
Enabled: false
Style/ColonMethodCall:
Enabled: false
Naming/FileName:
Enabled: false
Fix warnings and linter violations in inclusion matcher
2019-06-13 06:28:49 +00:00
Rails/Date:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Rails/Delegate:
Enabled: false
Fix warnings and linter violations in inclusion matcher
2019-06-13 06:28:49 +00:00
Rails/TimeZone:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Rails/HttpPositionalArguments:
Enabled: false
Style/Alias:
Enabled: false
Style/ArrayJoin:
Enabled: false
Style/AsciiComments:
Enabled: false
Style/Attr:
Enabled: false
Style/CaseEquality:
Enabled: false
Style/CharacterLiteral:
Enabled: false
Style/ClassAndModuleChildren:
Enabled: false
Update .rubocop.yml Import all of the Rubocop rules from Hound so that the comments that Hound produces are the same ones that would be produced in Vim. [ci skip]
2017-02-06 21:06:49 +00:00
Style/CollectionMethods:
Teach have_db_index about expression indexes In Rails 5, the schema layer was updated so that indexes could be created on expressions rather that simply columns. Update `have_db_index` so that you can test for this. More reading: <https://github.com/rails/rails/commit/edc2b7718725016e988089b5fb6d6fb9d6e16882>
2019-05-30 06:24:24 +00:00
Enabled: true
Rewrite tests for validate_uniqueness_of * The main problem I had with the old tests is that information that the reader didn't need to care about was not properly abstracted away. For instance, a helper method used by almost all tests will always create a model called Example, and will always use an attribute called "attr" (on which the validation is present). However, in some tests the class or attribute is referred to directly. The reader shouldn't have to care about either of these things, since they are constant -- the tests should be readable enough so that this information is not necessary to understand the case being tested against. * Speaking of this helper method, some of the tests used it and some didn't. Some defined their own helper methods to represent a particular case (`case_sensitive: true`, `allow_nil`, etc.). This is now fixed so that all but two tests use the same helper method to define a model. This model is completely customizable -- one can specify the type of the attribute being validated, the names and types of scoped attributes, etc. * The tests around scoped attributes and different types are all basically the same, so they are now compressed into a shared context. * Related to this, we no longer have to worry about setting a proper value for a scope attribute. One had to know which type that attribute had and come up with a reasonable default for that type. Now there is a helper method that worries about this automatically. * Finally, we remove tests around case_insensitive against an integer attribute (these don't make any sense, and don't work).
2015-02-08 19:10:23 +00:00
PreferredMethods:
find: detect
reduce: inject
collect: map
find_all: select
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Style/CommentAnnotation:
Enabled: false
Style/Documentation:
Enabled: false
Style/DoubleNegation:
Enabled: false
Style/EachWithObject:
Enabled: false
Turn off more Rubocop checks
2019-07-07 02:25:27 +00:00
Style/EmptyElse:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Style/EmptyLiteral:
Enabled: false
Style/Encoding:
Enabled: false
Style/EvenOdd:
Enabled: false
Style/FormatString:
Enabled: false
Update .rubocop.yml Import all of the Rubocop rules from Hound so that the comments that Hound produces are the same ones that would be produced in Vim. [ci skip]
2017-02-06 21:06:49 +00:00
Style/FrozenStringLiteralComment:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Style/GlobalVars:
Enabled: false
Style/GuardClause:
Enabled: false
Style/IfUnlessModifier:
Enabled: false
Style/IfWithSemicolon:
Enabled: false
Style/InlineComment:
Enabled: false
Style/Lambda:
Enabled: false
Style/LambdaCall:
Enabled: false
Style/LineEndConcatenation:
Enabled: false
Style/MethodCalledOnDoEndBlock:
Enabled: false
Style/ModuleFunction:
Enabled: false
Style/NegatedIf:
Enabled: false
Style/NegatedWhile:
Enabled: false
Style/Next:
Enabled: false
Style/NilComparison:
Enabled: false
Style/Not:
Enabled: false
Style/NumericLiterals:
Enabled: false
Style/NumericPredicate:
Enabled: false
Style/OneLineConditional:
Enabled: false
Fix warnings and linter violations in inclusion matcher
2019-06-13 06:28:49 +00:00
Style/ParenthesesAroundCondition:
Enabled: false
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Style/PercentLiteralDelimiters:
Enabled: false
Style/PerlBackrefs:
Enabled: false
Style/PreferredHashMethods:
Enabled: false
Style/Proc:
Enabled: false
Style/RaiseArgs:
Enabled: false
Style/RegexpLiteral:
Enabled: false
Style/SelfAssignment:
Enabled: false
Style/SignalException:
Enabled: false
Style/SingleLineBlockParams:
Enabled: false
Style/SingleLineMethods:
Enabled: false
Style/SpecialGlobalVars:
Enabled: false
Update .rubocop.yml Import all of the Rubocop rules from Hound so that the comments that Hound produces are the same ones that would be produced in Vim. [ci skip]
2017-02-06 21:06:49 +00:00
Style/StringLiterals:
EnforcedStyle: single_quotes
Simplify Rubocop configuration The original Rubocop configuration was copied from other thoughtbot projects. Of course, Rubocop comes with its own set of default settings. Therefore, we don't need to re-specify settings that it already has -- we only need to specify the ones that we're overriding. Besides this, Rubocop isn't even in the Gemfile, so even though Hound runs on GitHub automatically, it'd be nice to spot style issues as you are editing files. Given this, this commit simplifies the Rubocop configuration and also adds Rubocop to the Gemfile so that you can configure your editor to lint files as you are editing them.
2018-09-13 03:33:48 +00:00
Style/SymbolArray:
Enabled: false
Style/TrailingCommaInArguments:
EnforcedStyleForMultiline: consistent_comma
Style/TrailingCommaInArrayLiteral:
EnforcedStyleForMultiline: consistent_comma
Style/TrailingCommaInHashLiteral:
EnforcedStyleForMultiline: consistent_comma
Style/TrivialAccessors:
Enabled: false
Style/WhenThen:
Enabled: false
Style/WhileUntilModifier:
Enabled: false
Style/WordArray:
Enabled: false
Style/VariableInterpolation:
Enabled: false