gitlab-org--gitlab-foss/lib/api/issues.rb

235 lines
9.0 KiB
Ruby
Raw Normal View History

module API
2012-07-24 12:19:51 +00:00
class Issues < Grape::API
2016-11-07 14:15:14 +00:00
include PaginationParams
2012-07-24 12:19:51 +00:00
before { authenticate! }
2014-08-14 10:41:16 +00:00
helpers do
2014-09-04 22:01:12 +00:00
def filter_issues_state(issues, state)
2014-08-14 10:41:16 +00:00
case state
when 'opened' then issues.opened
when 'closed' then issues.closed
else issues
2014-08-14 10:41:16 +00:00
end
end
2014-08-14 14:17:19 +00:00
def filter_issues_labels(issues, labels)
2014-09-04 22:01:12 +00:00
issues.includes(:labels).where('labels.title' => labels.split(','))
end
def filter_issues_milestone(issues, milestone)
issues.includes(:milestone).where('milestones.title' => milestone)
2014-08-14 14:17:19 +00:00
end
2016-11-07 14:15:14 +00:00
params :issues_params do
optional :labels, type: String, desc: 'Comma-separated list of label names'
optional :order_by, type: String, values: %w[created_at updated_at], default: 'created_at',
desc: 'Return issues ordered by `created_at` or `updated_at` fields.'
optional :sort, type: String, values: %w[asc desc], default: 'desc',
desc: 'Return issues sorted in `asc` or `desc` order.'
use :pagination
end
2016-11-07 14:15:14 +00:00
params :issue_params do
optional :description, type: String, desc: 'The description of an issue'
optional :assignee_id, type: Integer, desc: 'The ID of a user to assign issue'
optional :milestone_id, type: Integer, desc: 'The ID of a milestone to assign issue'
optional :labels, type: String, desc: 'Comma-separated list of label names'
optional :due_date, type: String, desc: 'Date time string in the format YEAR-MONTH-DAY'
optional :confidential, type: Boolean, desc: 'Boolean parameter if the issue should be confidential'
optional :state_event, type: String, values: %w[open close],
desc: 'State of the issue'
end
2014-08-14 10:41:16 +00:00
end
2012-07-24 12:19:51 +00:00
resource :issues do
2016-11-07 14:15:14 +00:00
desc "Get currently authenticated user's issues" do
success Entities::Issue
end
params do
optional :state, type: String, values: %w[opened closed all], default: 'all',
desc: 'Return opened, closed, or all issues'
use :issues_params
end
2012-07-24 12:19:51 +00:00
get do
issues = current_user.issues.inc_notes_with_associations
2016-11-07 14:15:14 +00:00
issues = filter_issues_state(issues, params[:state])
2014-08-14 14:17:19 +00:00
issues = filter_issues_labels(issues, params[:labels]) unless params[:labels].nil?
2016-11-07 14:15:14 +00:00
issues = issues.reorder(params[:order_by] => params[:sort])
2016-09-09 14:16:14 +00:00
2016-04-08 06:41:10 +00:00
present paginate(issues), with: Entities::Issue, current_user: current_user
2012-07-24 12:19:51 +00:00
end
end
2016-11-07 14:15:14 +00:00
params do
requires :id, type: String, desc: 'The ID of a group'
end
resource :groups do
2016-11-07 14:15:14 +00:00
desc 'Get a list of group issues' do
success Entities::Issue
end
params do
optional :state, type: String, values: %w[opened closed all], default: 'opened',
desc: 'Return opened, closed, or all issues'
use :issues_params
end
get ":id/issues" do
2016-11-07 14:15:14 +00:00
group = find_group!(params.delete(:id))
params[:group_id] = group.id
params[:milestone_title] = params.delete(:milestone)
params[:label_name] = params.delete(:labels)
2016-09-09 14:16:14 +00:00
issues = IssuesFinder.new(current_user, params).execute
2016-11-07 14:15:14 +00:00
issues = issues.reorder(params[:order_by] => params[:sort])
present paginate(issues), with: Entities::Issue, current_user: current_user
end
end
params do
requires :id, type: String, desc: 'The ID of a project'
end
2012-07-24 12:19:51 +00:00
resource :projects do
2016-11-07 14:15:14 +00:00
desc 'Get a list of project issues' do
success Entities::Issue
end
params do
optional :state, type: String, values: %w[opened closed all], default: 'all',
desc: 'Return opened, closed, or all issues'
optional :iid, type: Integer, desc: 'The IID of the issue'
use :issues_params
end
2012-07-24 12:19:51 +00:00
get ":id/issues" do
Merge branch 'jej-use-issuable-finder-instead-of-access-check' into 'security' Replace issue access checks with use of IssuableFinder Split from !2024 to partially solve https://gitlab.com/gitlab-org/gitlab-ce/issues/23867 ## Which fixes are in this MR? :warning: - Potentially untested :bomb: - No test coverage :traffic_light: - Test coverage of some sort exists (a test failed when error raised) :vertical_traffic_light: - Test coverage of return value (a test failed when nil used) :white_check_mark: - Permissions check tested ### Issue lookup with access check Using `visible_to_user` likely makes these security issues too. See [Code smells](#code-smells). - [x] :vertical_traffic_light: app/finders/notes_finder.rb:15 [`visible_to_user`] - [x] :traffic_light: app/views/layouts/nav/_project.html.haml:73 [`visible_to_user`] [`.count`] - [x] :white_check_mark: app/services/merge_requests/build_service.rb:84 [`issue.try(:confidential?)`] - [x] :white_check_mark: lib/api/issues.rb:112 [`visible_to_user`] - CHANGELOG: Prevented API returning issues set to 'Only team members' to everyone - [x] :white_check_mark: lib/api/helpers.rb:126 [`can?(current_user, :read_issue, issue)`] Maybe here too? - [x] :white_check_mark: lib/gitlab/search_results.rb:53 [`visible_to_user`] ### Previous discussions - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#b2ff264eddf9819d7693c14ae213d941494fe2b3_128_126 - [ ] https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2024/diffs#7b6375270d22f880bdcb085e47b519b426a5c6c7_87_87 See merge request !2031
2016-11-22 10:25:04 +00:00
issues = IssuesFinder.new(current_user, project_id: user_project.id).execute.inc_notes_with_associations
2016-11-07 14:15:14 +00:00
issues = filter_issues_state(issues, params[:state])
2014-08-14 14:17:19 +00:00
issues = filter_issues_labels(issues, params[:labels]) unless params[:labels].nil?
issues = filter_by_iid(issues, params[:iid]) unless params[:iid].nil?
2014-09-04 22:01:12 +00:00
unless params[:milestone].nil?
issues = filter_issues_milestone(issues, params[:milestone])
end
2014-08-14 14:17:19 +00:00
2016-11-07 14:15:14 +00:00
issues = issues.reorder(params[:order_by] => params[:sort])
present paginate(issues), with: Entities::Issue, current_user: current_user, project: user_project
2012-07-24 12:19:51 +00:00
end
2016-11-07 14:15:14 +00:00
desc 'Get a single project issue' do
success Entities::Issue
end
params do
requires :issue_id, type: Integer, desc: 'The ID of a project issue'
end
2012-07-24 12:19:51 +00:00
get ":id/issues/:issue_id" do
2016-11-07 14:15:14 +00:00
issue = find_project_issue(params[:issue_id])
present issue, with: Entities::Issue, current_user: current_user, project: user_project
2012-07-24 12:19:51 +00:00
end
2016-11-07 14:15:14 +00:00
desc 'Create a new project issue' do
success Entities::Issue
end
params do
requires :title, type: String, desc: 'The title of an issue'
optional :created_at, type: DateTime,
desc: 'Date time when the issue was created. Available only for admins and project owners.'
optional :merge_request_for_resolving_discussions, type: Integer,
desc: 'The IID of a merge request for which to resolve discussions'
use :issue_params
end
2016-07-12 15:59:21 +00:00
post ':id/issues' do
2016-11-07 14:15:14 +00:00
# Setting created_at time only allowed for admins and project owners
unless current_user.admin? || user_project.owner == current_user
params.delete(:created_at)
end
2016-11-07 14:15:14 +00:00
issue_params = declared_params(include_missing: false)
if merge_request_iid = params[:merge_request_for_resolving_discussions]
2016-11-07 14:15:14 +00:00
issue_params[:merge_request_for_resolving_discussions] = MergeRequestsFinder.new(current_user, project_id: user_project.id).
execute.
find_by(iid: merge_request_iid)
end
2016-11-07 14:15:14 +00:00
issue = ::Issues::CreateService.new(user_project,
current_user,
issue_params.merge(request: request, api: true)).execute
if issue.spam?
render_api_error!({ error: 'Spam detected' }, 400)
end
if issue.valid?
present issue, with: Entities::Issue, current_user: current_user, project: user_project
else
render_validation_error!(issue)
2012-07-24 12:19:51 +00:00
end
end
desc 'Update an existing issue' do
success Entities::Issue
end
params do
2016-11-07 14:15:14 +00:00
requires :issue_id, type: Integer, desc: 'The ID of a project issue'
optional :title, type: String, desc: 'The title of an issue'
optional :updated_at, type: DateTime,
desc: 'Date time when the issue was updated. Available only for admins and project owners.'
use :issue_params
at_least_one_of :title, :description, :assignee_id, :milestone_id,
:labels, :created_at, :due_date, :confidential, :state_event
end
2016-07-12 15:59:21 +00:00
put ':id/issues/:issue_id' do
2016-11-07 14:15:14 +00:00
issue = user_project.issues.find(params.delete(:issue_id))
authorize! :update_issue, issue
2016-11-07 14:15:14 +00:00
# Setting created_at time only allowed for admins and project owners
unless current_user.admin? || user_project.owner == current_user
params.delete(:updated_at)
end
2016-07-15 14:21:53 +00:00
2016-11-07 14:15:14 +00:00
issue = ::Issues::UpdateService.new(user_project,
current_user,
declared_params(include_missing: false)).execute(issue)
2013-06-11 15:15:18 +00:00
if issue.valid?
present issue, with: Entities::Issue, current_user: current_user, project: user_project
else
render_validation_error!(issue)
2012-07-24 12:19:51 +00:00
end
end
2016-11-07 14:15:14 +00:00
desc 'Move an existing issue' do
success Entities::Issue
end
params do
requires :issue_id, type: Integer, desc: 'The ID of a project issue'
requires :to_project_id, type: Integer, desc: 'The ID of the new project'
end
2016-04-12 16:38:18 +00:00
post ':id/issues/:issue_id/move' do
2016-11-07 14:15:14 +00:00
issue = user_project.issues.find_by(id: params[:issue_id])
not_found!('Issue') unless issue
2016-04-07 12:07:17 +00:00
2016-11-07 14:15:14 +00:00
new_project = Project.find_by(id: params[:to_project_id])
not_found!('Project') unless new_project
2016-04-07 12:07:17 +00:00
begin
issue = ::Issues::MoveService.new(user_project, current_user).execute(issue, new_project)
present issue, with: Entities::Issue, current_user: current_user, project: user_project
2016-04-07 12:07:17 +00:00
rescue ::Issues::MoveService::MoveError => error
render_api_error!(error.message, 400)
end
end
2016-11-07 14:15:14 +00:00
desc 'Delete a project issue'
params do
requires :issue_id, type: Integer, desc: 'The ID of a project issue'
end
2012-07-24 12:19:51 +00:00
delete ":id/issues/:issue_id" do
2016-03-21 13:12:52 +00:00
issue = user_project.issues.find_by(id: params[:issue_id])
2016-11-07 14:15:14 +00:00
not_found!('Issue') unless issue
2016-02-26 08:55:43 +00:00
2016-03-21 13:12:52 +00:00
authorize!(:destroy_issue, issue)
2016-02-26 08:55:43 +00:00
issue.destroy
2012-07-24 12:19:51 +00:00
end
end
end
end