2012-10-09 08:14:17 +00:00
|
|
|
# == Schema Information
|
|
|
|
#
|
|
|
|
# Table name: notes
|
|
|
|
#
|
2012-11-19 18:24:05 +00:00
|
|
|
# id :integer not null, primary key
|
2012-10-09 08:14:17 +00:00
|
|
|
# note :text
|
|
|
|
# noteable_type :string(255)
|
|
|
|
# author_id :integer
|
2014-04-09 12:05:03 +00:00
|
|
|
# created_at :datetime
|
|
|
|
# updated_at :datetime
|
2012-10-09 08:14:17 +00:00
|
|
|
# project_id :integer
|
|
|
|
# attachment :string(255)
|
|
|
|
# line_code :string(255)
|
2013-01-03 19:09:18 +00:00
|
|
|
# commit_id :string(255)
|
|
|
|
# noteable_id :integer
|
2013-10-01 12:15:28 +00:00
|
|
|
# system :boolean default(FALSE), not null
|
2014-04-09 12:05:03 +00:00
|
|
|
# st_diff :text
|
2012-10-09 08:14:17 +00:00
|
|
|
#
|
|
|
|
|
2011-10-08 21:36:38 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
|
|
|
describe Note do
|
|
|
|
describe "Associations" do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to belong_to(:project) }
|
|
|
|
it { is_expected.to belong_to(:noteable) }
|
|
|
|
it { is_expected.to belong_to(:author).class_name('User') }
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
2012-09-26 18:17:17 +00:00
|
|
|
describe "Mass assignment" do
|
|
|
|
end
|
|
|
|
|
2011-10-08 21:36:38 +00:00
|
|
|
describe "Validation" do
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to validate_presence_of(:note) }
|
|
|
|
it { is_expected.to validate_presence_of(:project) }
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
2015-04-18 22:44:46 +00:00
|
|
|
describe 'voting score' do
|
|
|
|
it 'recognizes a neutral note' do
|
|
|
|
note = build(:votable_note, note: 'This is not a +1 note')
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).not_to be_upvote
|
|
|
|
expect(note).not_to be_downvote
|
2012-09-08 00:08:35 +00:00
|
|
|
end
|
|
|
|
|
2015-04-18 22:44:46 +00:00
|
|
|
it 'recognizes a neutral emoji note' do
|
2012-10-30 02:27:36 +00:00
|
|
|
note = build(:votable_note, note: "I would :+1: this, but I don't want to")
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).not_to be_upvote
|
|
|
|
expect(note).not_to be_downvote
|
2012-03-14 13:31:31 +00:00
|
|
|
end
|
|
|
|
|
2015-04-18 22:44:46 +00:00
|
|
|
it 'recognizes a +1 note' do
|
|
|
|
note = build(:votable_note, note: '+1 for this')
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_upvote
|
2012-03-14 13:31:31 +00:00
|
|
|
end
|
|
|
|
|
2015-04-18 22:44:46 +00:00
|
|
|
it 'recognizes a +1 emoji as a vote' do
|
|
|
|
note = build(:votable_note, note: ':+1: for this')
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_upvote
|
2012-09-06 19:31:25 +00:00
|
|
|
end
|
|
|
|
|
2015-04-18 22:44:46 +00:00
|
|
|
it 'recognizes a thumbsup emoji as a vote' do
|
|
|
|
note = build(:votable_note, note: ':thumbsup: for this')
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_upvote
|
2013-11-28 20:05:37 +00:00
|
|
|
end
|
|
|
|
|
2015-04-18 22:44:46 +00:00
|
|
|
it 'recognizes a -1 note' do
|
|
|
|
note = build(:votable_note, note: '-1 for this')
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_downvote
|
2012-09-08 00:08:35 +00:00
|
|
|
end
|
|
|
|
|
2015-04-18 22:44:46 +00:00
|
|
|
it 'recognizes a -1 emoji as a vote' do
|
|
|
|
note = build(:votable_note, note: ':-1: for this')
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_downvote
|
2012-09-06 19:31:25 +00:00
|
|
|
end
|
2013-11-28 20:05:37 +00:00
|
|
|
|
2015-04-18 22:44:46 +00:00
|
|
|
it 'recognizes a thumbsdown emoji as a vote' do
|
|
|
|
note = build(:votable_note, note: ':thumbsdown: for this')
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_downvote
|
2013-11-28 20:05:37 +00:00
|
|
|
end
|
2012-03-14 13:31:31 +00:00
|
|
|
end
|
|
|
|
|
2012-08-28 11:01:27 +00:00
|
|
|
let(:project) { create(:project) }
|
2012-03-14 13:31:31 +00:00
|
|
|
|
2012-08-28 11:01:27 +00:00
|
|
|
describe "Commit notes" do
|
2012-10-30 02:27:36 +00:00
|
|
|
let!(:note) { create(:note_on_commit, note: "+1 from me") }
|
|
|
|
let!(:commit) { note.noteable }
|
2012-01-21 12:54:32 +00:00
|
|
|
|
2012-10-13 14:23:12 +00:00
|
|
|
it "should be accessible through #noteable" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note.commit_id).to eq(commit.id)
|
|
|
|
expect(note.noteable).to be_a(Commit)
|
|
|
|
expect(note.noteable).to eq(commit)
|
2012-10-13 14:23:12 +00:00
|
|
|
end
|
|
|
|
|
2012-01-21 12:54:32 +00:00
|
|
|
it "should save a valid note" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note.commit_id).to eq(commit.id)
|
2012-10-30 02:27:36 +00:00
|
|
|
note.noteable == commit
|
2012-10-13 14:23:12 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should be recognized by #for_commit?" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_for_commit
|
2012-01-21 12:54:32 +00:00
|
|
|
end
|
|
|
|
|
2012-10-30 02:27:36 +00:00
|
|
|
it "should not be votable" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).not_to be_votable
|
2012-01-21 12:54:32 +00:00
|
|
|
end
|
2012-10-30 02:27:36 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe "Commit diff line notes" do
|
2013-01-15 13:19:14 +00:00
|
|
|
let!(:note) { create(:note_on_commit_diff, note: "+1 from me") }
|
2012-10-30 02:27:36 +00:00
|
|
|
let!(:commit) { note.noteable }
|
2012-01-21 12:54:32 +00:00
|
|
|
|
|
|
|
it "should save a valid note" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note.commit_id).to eq(commit.id)
|
|
|
|
expect(note.noteable.id).to eq(commit.id)
|
2012-10-13 14:23:12 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should be recognized by #for_diff_line?" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_for_diff_line
|
2012-10-30 02:27:36 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should be recognized by #for_commit_diff_line?" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_for_commit_diff_line
|
2012-10-30 02:27:36 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should not be votable" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).not_to be_votable
|
2012-10-30 02:27:36 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Issue notes" do
|
|
|
|
let!(:note) { create(:note_on_issue, note: "+1 from me") }
|
|
|
|
|
|
|
|
it "should not be votable" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_votable
|
2012-10-30 02:27:36 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Merge request notes" do
|
|
|
|
let!(:note) { create(:note_on_merge_request, note: "+1 from me") }
|
|
|
|
|
2013-05-30 23:16:49 +00:00
|
|
|
it "should be votable" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).to be_votable
|
2012-10-30 02:27:36 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe "Merge request diff line notes" do
|
2013-01-15 13:19:14 +00:00
|
|
|
let!(:note) { create(:note_on_merge_request_diff, note: "+1 from me") }
|
2012-10-30 02:27:36 +00:00
|
|
|
|
|
|
|
it "should not be votable" do
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(note).not_to be_votable
|
2012-01-21 12:54:32 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-05-30 23:16:49 +00:00
|
|
|
describe '#create_cross_reference_note' do
|
2014-01-22 19:03:52 +00:00
|
|
|
let(:project) { create(:project) }
|
2013-05-30 23:16:49 +00:00
|
|
|
let(:author) { create(:user) }
|
|
|
|
let(:issue) { create(:issue, project: project) }
|
2014-04-03 08:47:56 +00:00
|
|
|
let(:mergereq) { create(:merge_request, :simple, target_project: project, source_project: project) }
|
2015-04-21 13:13:40 +00:00
|
|
|
let(:commit) { project.commit }
|
2013-05-30 23:16:49 +00:00
|
|
|
|
|
|
|
# Test all of {issue, merge request, commit} in both the referenced and referencing
|
|
|
|
# roles, to ensure that the correct information can be inferred from any argument.
|
|
|
|
|
|
|
|
context 'issue from a merge request' do
|
2015-04-21 13:19:23 +00:00
|
|
|
subject { Note.create_cross_reference_note(issue, mergereq, author) }
|
2013-05-30 23:16:49 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to be_valid }
|
|
|
|
|
|
|
|
describe '#noteable' do
|
|
|
|
subject { super().noteable }
|
|
|
|
it { is_expected.to eq(issue) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#project' do
|
|
|
|
subject { super().project }
|
|
|
|
it { is_expected.to eq(issue.project) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#author' do
|
|
|
|
subject { super().author }
|
|
|
|
it { is_expected.to eq(author) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#note' do
|
|
|
|
subject { super().note }
|
2015-03-12 16:11:59 +00:00
|
|
|
it { is_expected.to eq("mentioned in merge request !#{mergereq.iid}") }
|
2015-02-12 18:17:35 +00:00
|
|
|
end
|
2013-05-30 23:16:49 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'issue from a commit' do
|
2015-04-21 13:19:23 +00:00
|
|
|
subject { Note.create_cross_reference_note(issue, commit, author) }
|
2013-05-30 23:16:49 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to be_valid }
|
|
|
|
|
|
|
|
describe '#noteable' do
|
|
|
|
subject { super().noteable }
|
|
|
|
it { is_expected.to eq(issue) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#note' do
|
|
|
|
subject { super().note }
|
2015-03-12 16:11:59 +00:00
|
|
|
it { is_expected.to eq("mentioned in commit #{commit.sha}") }
|
2015-02-12 18:17:35 +00:00
|
|
|
end
|
2013-05-30 23:16:49 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'merge request from an issue' do
|
2015-04-21 13:19:23 +00:00
|
|
|
subject { Note.create_cross_reference_note(mergereq, issue, author) }
|
2013-05-30 23:16:49 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to be_valid }
|
|
|
|
|
|
|
|
describe '#noteable' do
|
|
|
|
subject { super().noteable }
|
|
|
|
it { is_expected.to eq(mergereq) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#project' do
|
|
|
|
subject { super().project }
|
|
|
|
it { is_expected.to eq(mergereq.project) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#note' do
|
|
|
|
subject { super().note }
|
2015-03-12 16:11:59 +00:00
|
|
|
it { is_expected.to eq("mentioned in issue ##{issue.iid}") }
|
2015-02-12 18:17:35 +00:00
|
|
|
end
|
2013-05-30 23:16:49 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'commit from a merge request' do
|
2015-04-21 13:19:23 +00:00
|
|
|
subject { Note.create_cross_reference_note(commit, mergereq, author) }
|
2013-05-30 23:16:49 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to be_valid }
|
|
|
|
|
|
|
|
describe '#noteable' do
|
|
|
|
subject { super().noteable }
|
|
|
|
it { is_expected.to eq(commit) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#project' do
|
|
|
|
subject { super().project }
|
|
|
|
it { is_expected.to eq(project) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#note' do
|
|
|
|
subject { super().note }
|
2015-03-12 16:11:59 +00:00
|
|
|
it { is_expected.to eq("mentioned in merge request !#{mergereq.iid}") }
|
2015-02-12 18:17:35 +00:00
|
|
|
end
|
2013-05-30 23:16:49 +00:00
|
|
|
end
|
2014-02-07 10:34:30 +00:00
|
|
|
|
2014-11-05 11:18:26 +00:00
|
|
|
context 'commit contained in a merge request' do
|
2015-04-21 13:19:23 +00:00
|
|
|
subject { Note.create_cross_reference_note(mergereq.commits.first, mergereq, author) }
|
2014-11-05 11:18:26 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to be_nil }
|
2014-11-05 11:18:26 +00:00
|
|
|
end
|
|
|
|
|
2014-02-07 10:34:30 +00:00
|
|
|
context 'commit from issue' do
|
2015-04-21 13:19:23 +00:00
|
|
|
subject { Note.create_cross_reference_note(commit, issue, author) }
|
2014-02-07 10:34:30 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to be_valid }
|
|
|
|
|
|
|
|
describe '#noteable_type' do
|
|
|
|
subject { super().noteable_type }
|
|
|
|
it { is_expected.to eq("Commit") }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#noteable_id' do
|
|
|
|
subject { super().noteable_id }
|
|
|
|
it { is_expected.to be_nil }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#commit_id' do
|
|
|
|
subject { super().commit_id }
|
|
|
|
it { is_expected.to eq(commit.id) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#note' do
|
|
|
|
subject { super().note }
|
2015-03-12 16:11:59 +00:00
|
|
|
it { is_expected.to eq("mentioned in issue ##{issue.iid}") }
|
2015-02-12 18:17:35 +00:00
|
|
|
end
|
2014-02-07 10:34:30 +00:00
|
|
|
end
|
2014-10-06 12:07:36 +00:00
|
|
|
|
|
|
|
context 'commit from commit' do
|
|
|
|
let(:parent_commit) { commit.parents.first }
|
2015-04-21 13:19:23 +00:00
|
|
|
subject { Note.create_cross_reference_note(commit, parent_commit, author) }
|
2014-10-06 12:07:36 +00:00
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { is_expected.to be_valid }
|
|
|
|
|
|
|
|
describe '#noteable_type' do
|
|
|
|
subject { super().noteable_type }
|
|
|
|
it { is_expected.to eq("Commit") }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#noteable_id' do
|
|
|
|
subject { super().noteable_id }
|
|
|
|
it { is_expected.to be_nil }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#commit_id' do
|
|
|
|
subject { super().commit_id }
|
|
|
|
it { is_expected.to eq(commit.id) }
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#note' do
|
|
|
|
subject { super().note }
|
2015-03-12 16:11:59 +00:00
|
|
|
it { is_expected.to eq("mentioned in commit #{parent_commit.id}") }
|
2015-02-12 18:17:35 +00:00
|
|
|
end
|
2014-10-06 12:07:36 +00:00
|
|
|
end
|
2013-05-30 23:16:49 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
describe '#system?' do
|
|
|
|
let(:project) { create(:project) }
|
|
|
|
let(:issue) { create(:issue, project: project) }
|
|
|
|
let(:other) { create(:issue, project: project) }
|
|
|
|
let(:author) { create(:user) }
|
2013-12-26 16:50:29 +00:00
|
|
|
let(:assignee) { create(:user) }
|
2015-03-12 16:11:59 +00:00
|
|
|
let(:label) { create(:label) }
|
|
|
|
let(:milestone) { create(:milestone) }
|
2013-05-30 23:16:49 +00:00
|
|
|
|
|
|
|
it 'should recognize user-supplied notes as non-system' do
|
|
|
|
@note = create(:note_on_issue)
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(@note).not_to be_system
|
2013-05-30 23:16:49 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'should identify cross-reference notes as system notes' do
|
2015-04-21 13:19:23 +00:00
|
|
|
@note = Note.create_cross_reference_note(issue, other, author)
|
2015-02-12 18:17:35 +00:00
|
|
|
expect(@note).to be_system
|
2013-05-30 23:16:49 +00:00
|
|
|
end
|
2012-05-20 18:35:03 +00:00
|
|
|
end
|
|
|
|
|
2011-10-26 13:46:25 +00:00
|
|
|
describe :authorization do
|
|
|
|
before do
|
2012-08-28 11:01:27 +00:00
|
|
|
@p1 = create(:project)
|
2012-11-06 03:31:55 +00:00
|
|
|
@p2 = create(:project)
|
|
|
|
@u1 = create(:user)
|
|
|
|
@u2 = create(:user)
|
|
|
|
@u3 = create(:user)
|
2011-10-08 21:36:38 +00:00
|
|
|
@abilities = Six.new
|
|
|
|
@abilities << Ability
|
|
|
|
end
|
|
|
|
|
2011-10-26 13:46:25 +00:00
|
|
|
describe :read do
|
|
|
|
before do
|
2014-09-15 08:36:50 +00:00
|
|
|
@p1.project_members.create(user: @u2, access_level: ProjectMember::GUEST)
|
|
|
|
@p2.project_members.create(user: @u3, access_level: ProjectMember::GUEST)
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(@abilities.allowed?(@u1, :read_note, @p1)).to be_falsey }
|
|
|
|
it { expect(@abilities.allowed?(@u2, :read_note, @p1)).to be_truthy }
|
|
|
|
it { expect(@abilities.allowed?(@u3, :read_note, @p1)).to be_falsey }
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
2011-10-26 13:46:25 +00:00
|
|
|
describe :write do
|
|
|
|
before do
|
2014-09-15 08:36:50 +00:00
|
|
|
@p1.project_members.create(user: @u2, access_level: ProjectMember::DEVELOPER)
|
|
|
|
@p2.project_members.create(user: @u3, access_level: ProjectMember::DEVELOPER)
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(@abilities.allowed?(@u1, :write_note, @p1)).to be_falsey }
|
|
|
|
it { expect(@abilities.allowed?(@u2, :write_note, @p1)).to be_truthy }
|
|
|
|
it { expect(@abilities.allowed?(@u3, :write_note, @p1)).to be_falsey }
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
2011-10-26 13:46:25 +00:00
|
|
|
describe :admin do
|
|
|
|
before do
|
2014-09-15 08:36:50 +00:00
|
|
|
@p1.project_members.create(user: @u1, access_level: ProjectMember::REPORTER)
|
|
|
|
@p1.project_members.create(user: @u2, access_level: ProjectMember::MASTER)
|
|
|
|
@p2.project_members.create(user: @u3, access_level: ProjectMember::MASTER)
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
|
2015-02-12 18:17:35 +00:00
|
|
|
it { expect(@abilities.allowed?(@u1, :admin_note, @p1)).to be_falsey }
|
|
|
|
it { expect(@abilities.allowed?(@u2, :admin_note, @p1)).to be_truthy }
|
|
|
|
it { expect(@abilities.allowed?(@u3, :admin_note, @p1)).to be_falsey }
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|
|
|
|
end
|
2013-05-30 23:16:49 +00:00
|
|
|
|
|
|
|
it_behaves_like 'an editable mentionable' do
|
2015-04-16 20:25:25 +00:00
|
|
|
subject { create :note, noteable: issue, project: project }
|
|
|
|
|
2013-05-30 23:16:49 +00:00
|
|
|
let(:issue) { create :issue, project: project }
|
|
|
|
let(:backref_text) { issue.gfm_reference }
|
|
|
|
let(:set_mentionable_text) { ->(txt) { subject.note = txt } }
|
|
|
|
end
|
2011-10-08 21:36:38 +00:00
|
|
|
end
|