gitlab-org--gitlab-foss/spec/models/note_spec.rb

209 lines
6 KiB
Ruby
Raw Normal View History

2012-10-09 04:14:17 -04:00
# == Schema Information
#
# Table name: notes
#
2012-11-19 13:24:05 -05:00
# id :integer not null, primary key
2012-10-09 04:14:17 -04:00
# note :text
# noteable_type :string(255)
# author_id :integer
# created_at :datetime
# updated_at :datetime
2012-10-09 04:14:17 -04:00
# project_id :integer
# attachment :string(255)
# line_code :string(255)
2013-01-03 14:09:18 -05:00
# commit_id :string(255)
# noteable_id :integer
2013-10-01 08:15:28 -04:00
# system :boolean default(FALSE), not null
# st_diff :text
2015-09-06 10:48:48 -04:00
# updated_by_id :integer
2012-10-09 04:14:17 -04:00
#
2011-10-08 17:36:38 -04:00
require 'spec_helper'
describe Note do
2015-05-10 22:57:44 -04:00
describe 'associations' do
it { is_expected.to belong_to(:project) }
it { is_expected.to belong_to(:noteable) }
it { is_expected.to belong_to(:author).class_name('User') }
2011-10-08 17:36:38 -04:00
end
2015-05-10 22:57:44 -04:00
describe 'validation' do
it { is_expected.to validate_presence_of(:note) }
it { is_expected.to validate_presence_of(:project) }
2011-10-08 17:36:38 -04:00
end
2015-05-10 22:57:44 -04:00
describe '#votable?' do
it 'is true for issue notes' do
note = build(:note_on_issue)
expect(note).to be_votable
end
it 'is true for merge request notes' do
note = build(:note_on_merge_request)
expect(note).to be_votable
end
it 'is false for merge request diff notes' do
note = build(:note_on_merge_request_diff)
expect(note).not_to be_votable
end
it 'is false for commit notes' do
note = build(:note_on_commit)
expect(note).not_to be_votable
end
it 'is false for commit diff notes' do
note = build(:note_on_commit_diff)
expect(note).not_to be_votable
end
end
describe 'voting score' do
it 'recognizes a neutral note' do
note = build(:votable_note, note: 'This is not a +1 note')
expect(note).not_to be_upvote
expect(note).not_to be_downvote
2012-09-07 20:08:35 -04:00
end
it 'recognizes a neutral emoji note' do
2012-10-29 22:27:36 -04:00
note = build(:votable_note, note: "I would :+1: this, but I don't want to")
expect(note).not_to be_upvote
expect(note).not_to be_downvote
2012-03-14 09:31:31 -04:00
end
it 'recognizes a +1 note' do
note = build(:votable_note, note: '+1 for this')
expect(note).to be_upvote
2012-03-14 09:31:31 -04:00
end
it 'recognizes a +1 emoji as a vote' do
note = build(:votable_note, note: ':+1: for this')
expect(note).to be_upvote
end
it 'recognizes a thumbsup emoji as a vote' do
note = build(:votable_note, note: ':thumbsup: for this')
expect(note).to be_upvote
end
it 'recognizes a -1 note' do
note = build(:votable_note, note: '-1 for this')
expect(note).to be_downvote
2012-09-07 20:08:35 -04:00
end
it 'recognizes a -1 emoji as a vote' do
note = build(:votable_note, note: ':-1: for this')
expect(note).to be_downvote
end
it 'recognizes a thumbsdown emoji as a vote' do
note = build(:votable_note, note: ':thumbsdown: for this')
expect(note).to be_downvote
end
2012-03-14 09:31:31 -04:00
end
describe "Commit notes" do
2012-10-29 22:27:36 -04:00
let!(:note) { create(:note_on_commit, note: "+1 from me") }
let!(:commit) { note.noteable }
2012-01-21 07:54:32 -05:00
2012-10-13 10:23:12 -04:00
it "should be accessible through #noteable" do
expect(note.commit_id).to eq(commit.id)
expect(note.noteable).to be_a(Commit)
expect(note.noteable).to eq(commit)
2012-10-13 10:23:12 -04:00
end
2012-01-21 07:54:32 -05:00
it "should save a valid note" do
expect(note.commit_id).to eq(commit.id)
2012-10-29 22:27:36 -04:00
note.noteable == commit
2012-10-13 10:23:12 -04:00
end
it "should be recognized by #for_commit?" do
expect(note).to be_for_commit
2012-01-21 07:54:32 -05:00
end
2012-10-29 22:27:36 -04:00
end
describe "Commit diff line notes" do
2013-01-15 08:19:14 -05:00
let!(:note) { create(:note_on_commit_diff, note: "+1 from me") }
2012-10-29 22:27:36 -04:00
let!(:commit) { note.noteable }
2012-01-21 07:54:32 -05:00
it "should save a valid note" do
expect(note.commit_id).to eq(commit.id)
expect(note.noteable.id).to eq(commit.id)
2012-10-13 10:23:12 -04:00
end
it "should be recognized by #for_diff_line?" do
expect(note).to be_for_diff_line
2012-10-29 22:27:36 -04:00
end
it "should be recognized by #for_commit_diff_line?" do
expect(note).to be_for_commit_diff_line
2012-10-29 22:27:36 -04:00
end
it "should not be votable" do
expect(note).not_to be_votable
2012-10-29 22:27:36 -04:00
end
end
2015-05-10 22:57:44 -04:00
describe 'authorization' do
before do
@p1 = create(:project)
@p2 = create(:project)
@u1 = create(:user)
@u2 = create(:user)
@u3 = create(:user)
2011-10-08 17:36:38 -04:00
@abilities = Six.new
@abilities << Ability
end
2015-05-10 22:57:44 -04:00
describe 'read' do
before do
@p1.project_members.create(user: @u2, access_level: ProjectMember::GUEST)
@p2.project_members.create(user: @u3, access_level: ProjectMember::GUEST)
2011-10-08 17:36:38 -04:00
end
it { expect(@abilities.allowed?(@u1, :read_note, @p1)).to be_falsey }
it { expect(@abilities.allowed?(@u2, :read_note, @p1)).to be_truthy }
it { expect(@abilities.allowed?(@u3, :read_note, @p1)).to be_falsey }
2011-10-08 17:36:38 -04:00
end
2015-05-10 22:57:44 -04:00
describe 'write' do
before do
@p1.project_members.create(user: @u2, access_level: ProjectMember::DEVELOPER)
@p2.project_members.create(user: @u3, access_level: ProjectMember::DEVELOPER)
2011-10-08 17:36:38 -04:00
end
it { expect(@abilities.allowed?(@u1, :create_note, @p1)).to be_falsey }
it { expect(@abilities.allowed?(@u2, :create_note, @p1)).to be_truthy }
it { expect(@abilities.allowed?(@u3, :create_note, @p1)).to be_falsey }
2011-10-08 17:36:38 -04:00
end
2015-05-10 22:57:44 -04:00
describe 'admin' do
before do
@p1.project_members.create(user: @u1, access_level: ProjectMember::REPORTER)
@p1.project_members.create(user: @u2, access_level: ProjectMember::MASTER)
@p2.project_members.create(user: @u3, access_level: ProjectMember::MASTER)
2011-10-08 17:36:38 -04:00
end
it { expect(@abilities.allowed?(@u1, :admin_note, @p1)).to be_falsey }
it { expect(@abilities.allowed?(@u2, :admin_note, @p1)).to be_truthy }
it { expect(@abilities.allowed?(@u3, :admin_note, @p1)).to be_falsey }
2011-10-08 17:36:38 -04:00
end
end
it_behaves_like 'an editable mentionable' do
2015-04-16 16:25:25 -04:00
subject { create :note, noteable: issue, project: project }
2015-05-10 22:57:44 -04:00
let(:project) { create(:project) }
let(:issue) { create :issue, project: project }
let(:backref_text) { issue.gfm_reference }
let(:set_mentionable_text) { ->(txt) { subject.note = txt } }
end
describe :search do
let!(:note) { create(:note, note: "WoW") }
it { expect(Note.search('wow')).to include(note) }
end
2011-10-08 17:36:38 -04:00
end