Fatih Acet df629173d9 Merge branch '24807-stop-ddosing-ourselves' into 'master' ... Stop DDOSing ourselves ## What does this MR do? Adds `hiddenInterval` to `SmartInterval` settings. This will be the interval used whilst the tab is inactive. If this setting is not set it will `cancel` as it would have done before. Adds `immediateExecution` to `SmartInterval` settings. This boolean will dictate whether to execute the callback once before the first interval or not. Uses `SmartInterval` with the new `hiddenInterval` settings to slow the polling for the MR widget on inactive tabs. Fixes issue where `SmartInterval`s `visibilitychange` listeners are not getting called because jQuery doesn't support them. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? We're ddosing ourselves on the MR page. ## Screenshots (if relevant)  ~30 seconds difference between the first 2 requests _(a couple requests had fired already so it's backed off already)_. _-changed to different tab-_ ~2 minutes difference between the middle 2 requests. _-changed tab back to MR-_ ~10 seconds difference between the last 2 requests. ## Does this MR meet the acceptance criteria? - [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #24807 See merge request !7762		2016-12-12 15:45:54 +00:00
..
.gitkeep	Add changelogs/unreleased/.gitkeep	2016-09-09 14:37:25 -04:00
4269-public-api.yml	Allow public access to some Project API endpoints	2016-12-01 16:39:42 +01:00
7749-add-setting-to-disable-html-emails.yml	Add new configuration setting to enable/disable HTML emails.	2016-11-28 17:00:03 -05:00
15081-wrong-login-tab-ldap-frontend.yml	Fixed Wrong Tab Selected When Loggin Fails And Multiple Login Tabs Exists	2016-12-02 10:19:31 +01:00
18546-update-wiki-page-design.yml	add CHANGELOG entry for !7429	2016-11-30 15:22:43 -06:00
22373-reduce-queries-in-api-helpers-find_project.yml	Make API::Helpers find a project with only one query	2016-11-24 10:19:36 +01:00
22719-provide-a-new-gitlab-workhorse-install-rake-task-similar-to-gitlab-shell-install.yml	New gitlab:workhorse:install rake task	2016-11-30 10:34:59 +01:00
22781-user-generated-permalinks.yml	add CHANGELOG entry for !7631	2016-11-30 15:28:10 -06:00
23305-leave-project-and-leave-group-should-be-buttons.yml	Removed leave buttons from settings dropdowns	2016-11-26 14:27:08 +00:00
23500-enable-colorvariable.yml	Enable ColorVariable in scss-lint	2016-12-01 20:22:51 -05:00
23532-define-common-helper-for-describe-pagination-params-in-api.yml	Define common helper for describe pagination params in api	2016-11-22 09:19:26 +05:00
23589-open-issue-for-mr.yml	Feature: delegate all open discussions to Issue	2016-12-05 20:55:45 +01:00
23718-backup-rake-task-human-readable.yml	Add Human Readable Timestamp to backup tar file	2016-11-30 11:41:53 +01:00
24135-new-project-should-be-below-new-group-on-the-welcome-screen.yml	Moved groups above projects	2016-11-29 14:49:30 +00:00
24150-consistent-dropdown-styles.yml	Update the Changelog	2016-11-28 23:18:04 +01:00
24281-issue-merge-request-sidebar-subscribe-button-style-improvement.yml	Remove the help text under the sidebar subscribe button and style it inline	2016-11-30 17:15:25 -06:00
24413-show-unconfirmed-email-status.yml	changelog entry file added	2016-11-21 13:50:44 +06:00
24507_remove_deleted_branch_link_in_merge_request.yml	add link_to_if helper on target_branch link on Merge Request show page for case of deleted target branch	2016-12-08 01:06:23 +03:00
24576_cant_stop_impersonating.yml	Allow admins to stop impersonating users without e-mail addresses	2016-11-17 23:28:39 -05:00
24710-fix-generic-commit-status-table-row.yml	add CHANGELOG.md entry for !7811	2016-11-29 12:55:08 -06:00
24726-remove-across-gitlab.yml	24726 Remove Across GitLab from side navigation	2016-12-01 13:45:14 -08:00
24733-archived-project-merge-request-count.yml	Fix Archived project merge requests add to group's Merge Requests	2016-12-05 18:06:36 +01:00
24807-stop-ddosing-ourselves.yml	Added hiddenInterval and immediateExecution settings, fixed visibilitychange listening, implemented with mr widget	2016-12-12 15:56:11 +03:00
24844-environments-date.yml	Use created date from last_deployment	2016-11-30 12:44:42 +00:00
24921-hide-prompt-to-add-ssh-key-if-ssh-protocol-is-disabled.yml	If SSH prototol is disabled don't say the user requires SSH keys	2016-12-01 22:13:42 +10:00
24982-ux-improvement-sign-in-success-message.yml	fix: 24982- Remove'Signed in successfully' message	2016-12-07 20:30:28 +05:30
24999-fix-project-avatar-alignment.yml	Fix the width of project avatars in order to adjust alignment within their container element	2016-11-26 16:14:02 -05:00
25002-sentence-case-dashboard-tabs.yml	Changes project dashboard tabs to sentence casing	2016-11-26 23:34:19 -05:00
25011-hoverstates-for-collapsed-issue-merge-request-sidebar.yml	Adds hoverstates for collapsed Issue/Merge Request sidebar	2016-11-29 16:08:16 +01:00
25026-authenticate-user-for-new-snippet.yml	Ensure user is authenticated to create a new snippet	2016-11-28 16:57:49 +01:00
25031-do-not-raise-error-in-autocomplete.yml	Do not raise error in AutocompleteController#users when not authorized	2016-11-30 10:09:14 +05:00
25098-header-margins-on-pipeline-settings.yml	Fixed row margins on Pipeline Settings page in order to unify styles	2016-12-01 12:46:54 -05:00
25171-fix-mr-features-settings-hidden-when-builds-are-disabled.yml	Remove wrong '.builds-feature' class from the MR settings fieldset	2016-12-07 12:42:09 +01:00
25202-fix-mr-widget-content-wrapping.yml	Fixed MR widget content wrapping for XS viewports	2016-12-05 11:00:00 -05:00
25221-fix-build-status-overflow-mobile.yml	Added changelog for #25221	2016-12-03 19:21:04 -05:00
25251-actionview-template-error-undefined-method-text-for-nil-nilclass.yml	Fixes ActionView::Template::Error: undefined method text? for nil:NilClass	2016-12-02 14:03:30 +02:00
25264-ref-commit.yml	Adds changelog entry	2016-12-02 15:30:26 +00:00
25272_fix_comments_tab_disappearing.yml	remove unnecessary issues event filter on comments tab	2016-12-08 23:46:45 +03:00
25294-remove-signed-out-msg.yml	fix: removed signed_out notification	2016-12-12 15:04:48 +05:30
25324-change-housekeeping-btn-to-default.yml	Use default btn styling for Housekeeping button on projects settings page	2016-12-06 12:55:24 -05:00
25374-svg-as-prop.yml	Adds CHANGELOG entry	2016-12-09 10:14:48 +00:00
api-branch-status.yml	API: Expose branch status	2016-11-30 13:13:50 +01:00
api-delete-group-share.yml	API: Add endpoint to delete a group share	2016-11-23 12:53:37 +01:00
api-expose-commiter-details.yml	API: Expose committer details for a commit	2016-12-01 11:10:46 +01:00
api-remove-source-branch.yml	API: Ability to remove source branch	2016-12-04 16:52:42 +01:00
cleanup-common_utils-js.yml	Clean up common_utils.js (!7318)	2016-12-01 23:16:09 +01:00
comments-fixture.yml	Replace static fixture for notes_spec (!7683)	2016-12-01 15:04:07 +01:00
create-dynamic-fixture-for-build_spec.yml	Create dynamic fixture for build_spec (!7589)	2016-11-25 11:03:31 +01:00
destroy-session.yml	Merge branch 'destroy-session' into 'security'	2016-12-08 21:21:06 -03:00
dev-issue-24554.yml	Edit help text to clarify that tags are annotated.	2016-11-21 10:46:32 -08:00
do-not-refresh-main-when-fork-target-branch-updated.yml	Do not reload diff for merge request made from fork when target branch in fork is updated	2016-12-09 12:10:26 +01:00
dz-allow-nested-group-routing.yml	Add nested groups support to the routing	2016-11-23 14:08:36 +02:00
dz-nested-groups.yml	Add nested groups support on data level	2016-12-08 11:47:16 +02:00
emoji-btn-disabled.yml	Disabled award emoji button when user is not logged in	2016-11-22 10:25:09 +00:00
enable-asciidoctor-admonition-icons.yml	Enable display of admonition icons in Asciidoc.	2016-12-08 08:46:22 +09:00
feature-admin-user-groups-link.yml	The admin user projects view now has a clickable group link	2016-12-02 15:18:47 +00:00
features-api-snippets.yml	API: Endpoint to expose personal snippets as /snippets	2016-12-01 19:07:49 +01:00
fix-cancelling-pipelines.yml	Improve how we could cancel pipelines:	2016-11-17 20:22:57 +08:00
fix-create-pipeline-with-builds-in-transaction.yml	Add Changelog entry for pipeline creation improvements	2016-11-25 10:57:03 +01:00
fix-drop-project-authorized-for-user.yml	Update ProjectTeam#fetch_members to use project authorizations	2016-11-23 12:59:13 +02:00
fix-milestone-summary.yml	Add CHANGELOG entry	2016-12-08 17:09:26 -02:00
fix-rename-mwbs-to-merge-when-pipeline-succeeds.yml	Add Changelog entry for Merge When Pipeline Succeeds	2016-11-21 12:42:44 +01:00
glm-shorthand-reference.yml	Add shorthand support to gitlab markdown references	2016-12-02 19:18:17 -02:00
group-members-in-project-members-view.yml	Shows group members in the project members list	2016-12-02 16:49:53 +00:00
hoopes-gitlab-ce-21027-add-diff-hunks-to-notification-emails.yml	Fix CHANGELOG	2016-11-25 15:23:50 +00:00
html-safe-diff-line-content.yml	Merge branch 'html-safe-diff-line-content' into 'security'	2016-12-08 21:38:35 -03:00
improve-invite-accept-page.yml	Add a CHANGELOG entry	2016-11-29 11:29:07 -02:00
issuable_filters_present-refactor.yml	Refactor issuable_filters_present to reduce duplications	2016-11-28 14:48:03 +05:00
issue-24534.yml	Remove unnecessary sentences for status codes in the API documentation	2016-11-24 10:28:52 -07:00
issue-boards-scrollable-element.yml	Fixed issue boards scrolling with a lot of lists & issues	2016-11-24 16:54:24 +00:00
issue-events-filter.yml	Add issue events filter and make sure "All" really shows everything	2016-12-04 23:07:22 +01:00
issue_24020.yml	fix display hook error message	2016-12-05 22:02:45 +09:00
issue_24363.yml	Fix appearance in error pages	2016-11-29 11:44:07 -07:00
issue_24748.yml	Fix title case to sentence case	2016-11-23 16:34:58 -07:00
issue_24958.yml	Fix bad selection on dropdown menu for tags filter	2016-11-25 00:29:26 -07:00
issue_25030.yml	Allow branch names with dots on API endpoint	2016-12-08 16:39:56 -02:00
issues-1608-text.yml	change the date label to match the date used	2016-12-03 14:39:35 -07:00
jej-22869.yml	Merge branch 'jej-22869' into 'security'	2016-11-28 21:25:18 -03:00
jej-23867-use-mr-finder-instead-of-access-check.yml	Merge branch 'jej-23867-use-mr-finder-instead-of-access-check' into 'security'	2016-12-08 21:42:07 -03:00
jej-fix-missing-access-check-on-issues.yml	Merge branch 'jej-fix-missing-access-check-on-issues' into 'security'	2016-11-28 21:25:46 -03:00
jej-use-issuable-finder-instead-of-access-check.yml	Merge branch 'jej-use-issuable-finder-instead-of-access-check' into 'security'	2016-11-28 21:26:23 -03:00
members-dropdowns.yml	Updated members dropdowns	2016-12-07 15:27:14 +00:00
milestone_start_date.yml	Add a starting date to milestones	2016-11-23 13:41:04 +02:00
move-abuse-report-spinach-test-to-rspec.yml	Move abuse report spinach test to rspec	2016-11-23 19:30:07 +05:00
move-admin-abuse-report-spinach-test-to-rspec.yml	Move admin abuse report spinach test to rspec	2016-11-23 21:40:29 +05:00
move-admin-hooks-spinach-test-to-rspec.yml	Move admin hooks spinach to rspec	2016-12-06 22:58:15 +05:00
move-admin-logs-spinach-test-to-rspec.yml	Move admin logs spinach test to rspec	2016-12-06 22:16:32 +05:00
move-admin-spam-spinach-test-to-rspec.yml	Move admin spam spinach test to Rspec	2016-11-23 20:18:35 +05:00
mr-origin-7855.yml	Added a changelog entry	2016-12-02 12:13:28 -05:00
post_receive-any-email.yml	post_receive: accept any user email from last commit	2016-11-04 15:44:57 +02:00
public-tags-api.yml	Allow public access to some Tag API endpoints	2016-12-07 11:39:11 +01:00
readme-link-fix.yml	Fix broken README.md UX guide link.	2016-11-28 15:51:57 -05:00
refactor-create-service-spec.yml	Refactor create service spec	2016-11-22 21:23:07 +05:00
remove-backup-strategies.yml	Stop supporting Google and Azure as backup strategies	2016-11-24 13:07:24 +01:00
remove-jsx-react-eslint-plugins.yml	Remove JSX/React eslint plugins.	2016-11-29 16:15:47 +00:00
remove-require-from-services.yml	Remove unnecessary require_relative calls from service classes	2016-11-22 11:25:00 +05:00
remove-unnecessary-self-from-user-model.yml	Remove unnecessary self from user model	2016-11-19 02:51:39 +05:00
removing_unnecessary_indexes.yml	Remove unnecessary database indexes	2016-11-29 14:40:48 +02:00
render-svg-in-diffs-and-notes.yml	Render SVG as images in notes	2016-12-08 00:29:43 -02:00
repository-name-emojis	Added ability to put emojis into repository name	2016-11-12 09:21:23 +01:00
right-sidebar-fixture.yml	Replace static fixture for right_sidebar_spec (!7687)	2016-11-28 20:34:45 +01:00
rs-project-team-helpers.yml	Add shortcuts for adding users to a project team with a specific role	2016-11-18 14:55:04 +02:00
shortcuts-issuable-fixture.yml	Replace static fixture for shortcuts_issuable_spec (!7685)	2016-11-23 01:13:36 +01:00
simplify-create-new-list-issue-boards.yml	Simplify copy on "Create a new list" dropdown in Issue Boards	2016-11-23 17:28:58 -02:00
small-emoji-adjustments.yml	Various small emoji positioning adjustments	2016-12-08 14:35:17 +01:00
timeago-perf-fix.yml	Fixed timeago re-rendering every element	2016-12-07 12:44:47 +00:00
update-api-spec-files.yml	Changed API spec files to describe the correct class	2016-11-28 10:55:27 -07:00
update-button-font-weight.yml	Updates the font weight of button styles because of the change to system fonts	2016-12-09 16:46:03 +01:00
update-git-version-in-doc.yml	Bump Git version requirement to 2.8.4	2016-12-01 16:18:09 +01:00
use-st-commits-where-possible.yml	Replace references to MergeRequestDiff#commits with st_commits	2016-12-01 12:17:30 +01:00
validate-state-param-when-filtering-issuables.yml	Merge branch 'issue_25064' into 'security'	2016-12-06 12:26:48 +11:00
zen-mode-fixture.yml	Replace static fixture for zen_mode_spec (!7686)	2016-11-23 01:29:32 +01:00
zj-expose-coverage-pipelines.yml	Expose coverage on GET pipelines/:id	2016-11-25 15:49:59 +01:00
zj-fix-label-creation-non-members.yml	Merge branch 'zj-fix-label-creation-non-members' into 'security'	2016-11-28 21:24:19 -03:00
zj-guest-reads-public-builds.yml	Guests can read builds if those are public	2016-12-04 15:48:50 +01:00
zj-issue-new-over-issue-create.yml	Accept issue new as command to create an issue	2016-12-05 10:02:21 +01:00
zj-issue-search-slash-command.yml	Add issue search slash command	2016-11-25 15:41:28 +01:00
zj-use-ruby-2-3-3.yml	Bump ruby version	2016-12-03 15:57:20 +01:00